[JEP-202] Add more detail #97
Conversation
about the reasoning and implementation Address comments in jenkinsci#96
|
|
||
| We opted for the first, simpler option. | ||
|
|
||
| == Backwards Compatibility |
There was a problem hiding this comment.
eek, GitHub diff is getting confused, may trigger merge conflicts with #98 but OK
jep/202/README.adoc
Outdated
| Currently this is a environment variable but could be a system property or a config section in the UI. | ||
|
|
||
| However: | ||
| This means that different runs can not store the artifacts in different buckets or paths, as we don't expect that to be a common use case. |
jep/202/README.adoc
Outdated
| Having access to the blob store would mean access to other jobs artifacts. | ||
|
|
||
| Agents only do URL based upload/download operations and get the correct url to do so from the master. | ||
| Extra care needs to be taken so agents do not have any access to the blob store. |
There was a problem hiding this comment.
Can delete this sentence now? Or shift to the next paragraph?
|
|
||
| http://javadoc.jenkins.io/hudson/FilePath.html[`FilePath`] | ||
|
|
||
| * `copyFromRemotely(URL)` Copies the content of a URL to a remote file without transferring content over a Remoting channel |
There was a problem hiding this comment.
doRemoteCopy might be a clearer name? BTW. I'm aware it's a change upstream, but as @jglick vented "it's still in Beta after all" :)
There was a problem hiding this comment.
My main issue is that that would not obviously be a drop-in replacement for copyFrom(URL), as this is.
|
|
||
|
|
||
| This change adds more methods to the VirtualFile API to support this flow. | ||
| This change adds more methods to the http://javadoc.jenkins.io/jenkins/util/VirtualFile.html[`VirtualFile`] API to support this flow. |
|
|
||
|
|
||
| This change adds more methods to the VirtualFile API to support this flow. | ||
| This change adds more methods to the http://javadoc.jenkins.io/jenkins/util/VirtualFile.html[`VirtualFile`] API to support this flow. |
There was a problem hiding this comment.
Currently Javadoc site does not list the methods. Maybe makes sense to add return type and throws to have a full method signature
There was a problem hiding this comment.
the javadoc is now updated
jep/202/README.adoc
Outdated
| Having access to the blob store would mean access to other jobs artifacts. | ||
|
|
||
| Agents only do URL based upload/download operations and get the correct url to do so from the master. | ||
| Extra care needs to be taken so agents do not have any access to the blob store. |
|
@carlossg do you plan to address the comments? |
5 participants
about the reasoning and implementation
Address comments in #96