Skip to content

Suppressing some tests which fail in CI #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 4 commits into from
Dec 11, 2018
Merged

Suppressing some tests which fail in CI #3799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50df563
Suppressing some tests which fail in CI.
jglick Dec 10, 2018
0ee685e
Un-ignore test that was fixed
batmat Dec 11, 2018
99835d6
Revert the whitespace addition as well
Wadeck Dec 11, 2018
25823d9
Clarifying reason for suppression.
jglick Dec 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/test/java/hudson/FilePathSEC904Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,15 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeTrue;
import org.junit.Ignore;

//TODO to be merged back in FilePathTest after security release
public class FilePathSEC904Test {

@Rule
public TemporaryFolder temp = new TemporaryFolder();


@Ignore("./../workspace fails on CI")
@Test
@Issue("SECURITY-904")
public void isDescendant_regularFiles() throws IOException, InterruptedException {
Expand Down
1 change: 1 addition & 0 deletions core/src/test/java/hudson/UtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ public void testDeleteContentsRecursive() throws Exception {
assertFalse("f1 exists", f1.exists());
}

@Ignore("TODO often fails in CI")
Copy link
Member Author

@jglick jglick Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has long been flaky. #3787 forgot this one.

Copy link
Member

@daniel-beck daniel-beck Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps better to assume not running in a CI environment? https://github.com/auchenberg/volkswagen/ light?

Copy link
Contributor

@Wadeck Wadeck Dec 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in progress for this one in #3721. Otherwise we will have 2 @Ignore and the compilation will fail. (Sorry "ignore" user for the ping)

Copy link
Member Author

@jglick jglick Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, would just be a trivial merge conflict.

@Test
public void testDeleteContentsRecursive_onWindows() throws Exception {
Assume.assumeTrue(Functions.isWindows());
Expand Down
2 changes: 2 additions & 0 deletions test/src/test/java/hudson/PluginSEC925Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.Future;
import org.junit.Ignore;

//TODO merge it within PluginTest after the security release
public class PluginSEC925Test {

@Rule
public JenkinsRule r = new JenkinsRule();

@Ignore("TODO observed to fail in CI with 404")
Copy link
Member Author

@jglick jglick Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some sort of network outage, it seems.

Copy link
Member

@daniel-beck daniel-beck Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems unnecessary, haven't seen it fail a substantial number of times.

Copy link
Member Author

@jglick jglick Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I have seen it fail for reasons which were clearly tied to issues completely unrelated to core code. There are other UC-dependent tests which have been suppressed for the same reason.

@Test
@Issue("SECURITY-925")
public void preventTimestamp2_toBeServed() throws Exception {
Expand Down
2 changes: 2 additions & 0 deletions test/src/test/java/hudson/cli/CLITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.junit.Ignore;

public class CLITest {

Expand Down Expand Up @@ -256,6 +257,7 @@ public void redirectToEndpointShouldBeFollowed() throws Exception {
}
}

@Ignore("TODO sometimes fails, in CI & locally")
Copy link
Member Author

@jglick jglick Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3708 does not seem to have worked reliably.

@Test
@Issue("JENKINS-54310")
public void readInputAtOnce() throws Exception {
Expand Down
2 changes: 2 additions & 0 deletions test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package hudson.util;

import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.jvnet.hudson.test.Issue;
import org.jvnet.hudson.test.JenkinsRule;
Expand All @@ -23,6 +24,7 @@ public class AtomicFileWriterPerfTest {
* So using slightly more than the worse value obtained above should avoid making this flaky and still catch
* <strong>really</strong> bad performance regressions.
*/
@Ignore("TODO often fails in CI")
Copy link
Member Author

@jglick jglick Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3797 (review)

Copy link
Member

@daniel-beck daniel-beck Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, perhaps just assume not running in CI?

Copy link
Member

@batmat batmat Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea, because this test is unlikely to ever fail in a normal environment (I mean something built after ~1995), and at the same time I feel a bit bad if tests run locally are not the same as in CI. I see potential interesting headaches for some people if some tests fail locally but not in CI (though I suppose a comment would help about this...)

Copy link
Member Author

@jglick jglick Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is unlikely to ever fail in a normal environment

Possibly so, but performance tests are not suitable as merge/deploy gates—I could be patching README.md and the build might be marked as a failure for reasons unrelated to my change. Or, as in #3778, I could be trying to get a binary published for some unrelated fix and be stymied by this flake.

Better to have these in a separate job (repo?) where they are run say on a daily basis with some kind of tooling to track trends and alert developers to consistent regressions.

@Issue("JENKINS-34855")
@Test(timeout = 50 * 1000L)
public void poorManPerformanceTestBed() throws Exception {
Expand Down