Skip to content

Use Matrix Project Plugin in Security914Test, not Credentials Plugin #26090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 1 commit into from
Jan 8, 2026
Merged

Use Matrix Project Plugin in Security914Test, not Credentials Plugin #26090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/src/test/java/jenkins/security/stapler/Security914Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ void setUp(JenkinsRule rule) {
void cannotUseInvalidLocale_toTraverseFolder() throws Exception {
assumeTrue(Functions.isWindows());

assertNotNull(j.getPluginManager().getPlugin("credentials"));
j.createWebClient().goTo("plugin/credentials/images/credentials.svg", "image/svg+xml");
assertNotNull(j.getPluginManager().getPlugin("matrix-project"));
j.createWebClient().goTo("plugin/matrix-project/images/matrixproject.svg", "image/svg+xml");

JenkinsRule.WebClient wc = j.createWebClient()
.withThrowExceptionOnFailingStatusCode(false);
WebRequest request = new WebRequest(new URI(j.getURL() + "plugin/credentials/.xml").toURL());
WebRequest request = new WebRequest(new URI(j.getURL() + "plugin/matrix-project/.xml").toURL());
// plugin deployed in: test\target\jenkins7375296945862059919tmp
// rootDir is in : test\target\jenkinsTests.tmp\jenkins1274934531848159942test
// j.jenkins.getRootDir().getName() = jenkins1274934531848159942test
Expand All @@ -75,12 +75,12 @@ void cannotUseInvalidLocale_toTraverseFolder() throws Exception {
void cannotUseInvalidLocale_toAnyFileInSystem() throws Exception {
assumeTrue(Functions.isWindows());

assertNotNull(j.getPluginManager().getPlugin("credentials"));
j.createWebClient().goTo("plugin/credentials/images/credentials.svg", "image/svg+xml");
assertNotNull(j.getPluginManager().getPlugin("matrix-project"));
j.createWebClient().goTo("plugin/matrix-project/images/matrixproject.svg", "image/svg+xml");

JenkinsRule.WebClient wc = j.createWebClient()
.withThrowExceptionOnFailingStatusCode(false);
WebRequest request = new WebRequest(new URI(j.getURL() + "plugin/credentials/.ini").toURL());
WebRequest request = new WebRequest(new URI(j.getURL() + "plugin/matrix-project/.ini").toURL());
// ../ can be multiply to infinity, no impact, we just need to have enough to reach the root
request.setAdditionalHeader("Accept-Language", "../../../../../../../../../../../../windows/win");

Expand Down
Loading