Skip to content

Conversation

@jglick
Copy link
Member

@jglick jglick commented Sep 11, 2025

#6464 reapplied, reverting #6519.

Testing done

Fails as described (interactively) unless jenkinsci/credentials-plugin#651 is applied.

Proposed changelog entries

  • Improve the display of help text for agent launch methods.

Proposed changelog category

/label rfe

Proposed upgrade guidelines

You should first make sure you have updated the credentials plugin to at least version 1447.v4cb_b_539b_5321.

Desired reviewers

@mawinter69 @jenkinsci/sig-ux

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Sep 11, 2025
@jglick jglick marked this pull request as ready for review September 12, 2025 18:06
@timja timja requested a review from a team September 12, 2025 21:14
@jglick jglick requested review from a team and mawinter69 September 12, 2025 22:08
@timja
Copy link
Member

timja commented Sep 13, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 13, 2025
@timja timja merged commit 69e4425 into jenkinsci:master Sep 17, 2025
18 checks passed
@jglick jglick deleted the launcherdropdown branch September 17, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants