-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[border_css_util] implement css helper class #10057
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Thorsten Scherler <[email protected]>
Hey, thanks! Is there a specific use case for these utils? Curious, wondering if it should be like the colours where we have a base palette but then a semantic set on top of them with specific meaning. |
Mainly I was looking into this because of |
Ah gotcha. Is there any chance you could share a pic of what those buttons look like? Might be worth making a new type of button rather than a util library if its limited to that. |
... to be honest (but that is me loving CSS util classes) I think the border helper is much more versatile and it is in the spirit of the spacing util classes |
I have created a PoC
|
created an alternative PR #10061 |
This PR will provide CSS helper classes to add borders. It is similar to https://weekly.ci.jenkins.io/design-library/Spacing/ but takes more the way https://tailwindcss.com/docs/border-width works e.g.
jenkins-border-t-3
will create a top border of 3 pxfollow up pr will be created for https://weekly.ci.jenkins.io/design-library
Testing done
After compile you can change the source code to
Proposed changelog entries
CSS helper classes to add borders in the spirit of the
jenkins-!-spacing
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist