Skip to content

Conversation

@strangelookingnerd
Copy link
Contributor

Enable spotless and format all sources.

See comment in #988 (comment)

Once merged, commit hash needs to be added to git-blame-ignore-revs (see https://github.com/jenkinsci/plugin-pom/?tab=readme-ov-file#formatting)

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@strangelookingnerd
Copy link
Contributor Author

Kind of confused by the error, maybe something in my local setup? jenkinsci/pom#681?

@timja
Copy link
Member

timja commented Jul 3, 2025

Looks like line endings, I've ran it on my machine

@timja timja added the chore label Jul 3, 2025
@timja
Copy link
Member

timja commented Jul 3, 2025

If you run it on your machine does it try revert it back? Are you using Windows?

Maybe there's a setting we need to enable or gitattributes needed?

@strangelookingnerd
Copy link
Contributor Author

If you run it on your machine does it try revert it back? Are you using Windows?

Maybe there's a setting we need to enable or gitattributes needed?

No, it remains unchanged.
Yes, I'm on Windows. Not sure why only that one file was affected. I had similar issues in the past but thought I fixed it.

@timja timja merged commit 4e7b7d3 into jenkinsci:master Jul 3, 2025
15 checks passed
@strangelookingnerd strangelookingnerd deleted the spotless branch July 3, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants