Make fewer assumptions about log handling #37
Conversation
| } | ||
| RunningBuild build = new RunningBuild(r); | ||
| RunningBuild orig = builds.put(r.getLogFile(), build); | ||
| RunningBuild orig = builds.put(r.getRootDir(), build); |
There was a problem hiding this comment.
We just needed a unique identifier of a build × $JENKINS_HOME; were not actually using the log file per se.
There was a problem hiding this comment.
Won't help with ExternalTaskLogging story
There was a problem hiding this comment.
If you are referring to logging from non-Runs, that is true, but anyway BuildWatcher does not support them currently either.
| synchronized void copy() { | ||
| try { | ||
| pos = log.writeLogTo(pos, sink); | ||
| pos = r.getLogText().writeLogTo(pos, sink); |
There was a problem hiding this comment.
See this precedent. getLogText in general needs to be called repeatedly as more log output arrives.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
2 participants
Needed for jenkinsci/workflow-job-plugin#27, but generally should be an improvement.
@reviewbybees