Skip to content

[JENKINS-76271] In case of error in an http request, to log also de returned data #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akash-manna-sky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-76271] In case of error in an http request, to log also de returned data #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/jenkins/plugins/http_request/HttpRequestExecution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,18 @@
return;
}
}
// Log response body to help debug errors from REST APIs (only if not already logged)
if (!consoleLogResponseBody) {
try {
String content = response.getContent();
if (content != null && !content.isEmpty()) {

Check warning on line 509 in src/main/java/jenkins/plugins/http_request/HttpRequestExecution.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 509 is only partially covered, 2 branches are missing
logger().println("Response: \n" + content);
}
} catch (Exception e) {
// Ignore errors when trying to read response content
logger().println("Unable to read response body: " + e.getMessage());

Check warning on line 514 in src/main/java/jenkins/plugins/http_request/HttpRequestExecution.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 512-514 are not covered by tests
}
}
throw new AbortException("Fail: Status code " + response.getStatus() + " is not in the accepted range: " + validResponseCodes + " while calling " + url);
}

Expand Down
Loading