Test more versions of Jenkins core #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broader compilation checks with multiple Java versions and slightly broader test coverage by checking multiple Jenkins versions.
jglick
reviewed
Nov 11, 2022
| Collection<Trigger> triggerList = p.getTriggers().values(); | ||
| for (Trigger t : triggerList) { | ||
| ParameterizedJobMixIn.ParameterizedJob<?, ?> p = (ParameterizedJobMixIn.ParameterizedJob) job; | ||
| Collection<Trigger<?>> triggerList = p.getTriggers().values(); |
Contributor
Author
Member
There was a problem hiding this comment.
FYI, topologically (not squash- or rebase-) merging this PR would cause #1358 to be considered merged as well, I think according to Release Drafter too.
Member
There was a problem hiding this comment.
Basically, a PR is “merged” when either
- it was squash- or rebase-merged by GitHub; or
- its head commit becomes an ancestor of its base branch, by any means (including e.g.
git mergewithout any GH-specific tools).
MarkEWaite
changed the title
Contributor
Author
|
@gounthar or @jmMeessen could you approve this pull request? Sorry to bother you on a holiday, but it is easier if another maintainer approves the pull request. If no approval is received, I'll override and merge it myself without the extra approval. |
basil
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test more versions of Jenkins core