feat(updating reregisterallhooks method): only register parent, not all children #241
Conversation
src/main/java/org/jenkinsci/plugins/github/util/JobInfoHelpers.java
Outdated
Show resolved
Hide resolved
…ll children Instead of trying to register a webhook for each child job in a multibranch-pipeline project, only register the base project
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
No particular opinion; did not realize this plugin even registered hooks to begin with. github-branch-source also does so, though this style should probably be considered deprecated: better to use an App which automatically receives webhooks for anything it is installed on.
src/main/java/org/jenkinsci/plugins/github/util/JobInfoHelpers.java
Outdated
Show resolved
Hide resolved
I haven't really used the github-branch-source approach via the github app yet, possibly a better solution in general for auto scanning repos and such. I was having other issues and I followed this guide and that is when I came across the
button and saw that it had an issue with the child jobs... |
src/main/java/org/jenkinsci/plugins/github/util/JobInfoHelpers.java
Outdated
Show resolved
Hide resolved
|
FYI jenkinsci/github-branch-source-plugin#289, still on my back burner. |
4 participants
Instead of trying to register a webhook for each child job in a multibranch-pipeline project, only
register the base project.
With many multibranch pipelines and many prs/branches per project, the total number of calls to github (in my case github enterprise) can become very large and cause rate limiting/abuse rate limiting to be reached