Skip to content

[JENKINS-58942] Honor -Djenkins.hook.url=… if defined #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitwiseman merged 4 commits into from
Sep 11, 2019
Merged

[JENKINS-58942] Honor -Djenkins.hook.url=… if defined #240

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1ae498
Honor $JENKINS_HOOK_URL if defined.
jglick Aug 14, 2019
a4f167b
Merge branch 'master' into JENKINS_HOOK_URL
jglick Sep 9, 2019
c51604d
Deleting unused method existsHook.
jglick Sep 9, 2019
9941d05
WireMock test for overridden hook URL.
jglick Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubOrgWebHook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ private static boolean existsHook(GHOrganization org, String url) throws IOExcep
}

public static void register(GitHub hub, String orgName) throws IOException {
String rootUrl = Jenkins.getActiveInstance().getRootUrl();
String rootUrl = System.getenv("JENKINS_HOOK_URL");
if (rootUrl == null) {
rootUrl = Jenkins.get().getRootUrl();
}
if (rootUrl == null) {
return;
}
Expand Down