Jenkins 13493 - Automatic git cache maintenance

[Hrushi20]

JENKINS-13493 - Automatic git cache maintenance

This PR adds git maintenance to the Jenkins controller to optimize the git caches on the controller.

Please refer to Project Page for reference and design:
https://www.jenkins.io/projects/gsoc/2022/projects/automatic-git-cache-maintenance/

Checklist

• I have read the CONTRIBUTING doc
• I have referenced the Jira issue related to my changes in one or more commit messages
• I have added tests that verify my changes
• Unit tests pass locally with my changes
• I have added documentation as necessary
• No Javadoc warnings were introduced with my changes
• No spotbugs warnings were introduced with my changes
• Documentation in README has been updated as necessary
• Online help has been added and reviewed for any new or modified fields
• I have interactively tested my changes
• Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

• New feature (non-breaking change which adds functionality)

[Hrushi20]

Thank You @MarkEWaite for fixing those tests.

[MarkEWaite]

@Hrushi20 it appears there are testing failing in the CI job that were not failing before. I'm on vacation and won't be able to investigate for several weeks. If you have time over the next few weeks, it would be very nice if you could investigate the test failures.

[Hrushi20]

Sure @MarkEWaite I'll look into it. Enjoy your vacation.

[Hrushi20]

Hello @MarkEWaite, I have gone through the failed tests. I realized that the below code is not creating a cache on the Jenkins controller.

        sampleRepo1.init();
        sampleRepo1.git("checkout", "-b", "bug/JENKINS-42817");
        sampleRepo1.write("file", "modified");
        sampleRepo1.git("commit", "--all", "--message=dev");

        SCMFileSystem fs = SCMFileSystem.of(j.createFreeStyleProject(), new GitSCM(GitSCM.createRepoList(sampleRepo1.toString(), null), Collections.singletonList(new BranchSpec("*/bug/JENKINS-42817")), null, null, Collections.emptyList()));

Before I could access the caches, but now I am not able to create caches.
Also, Java 8 clears all the tests. Java 11 and Java 17 fails this test.

Is there a way to create a MultibranchPipeline so that it handle creating the caches.

[Hrushi20]

Hello @MarkEWaite, can you help me fix these failing tests. The problem I am facing right now is that I am not able to create fake caches during tests.

[MarkEWaite]

Hello @MarkEWaite, can you help me fix these failing tests. The problem I am facing right now is that I am not able to create fake caches during tests.

I won't be able to help with these tests until after I've completed the release of git client plugin 4.0.0 and git plugin 5.0.0. Those releases are getting all the time that I can allocate to the git plugin and git client plugin.

[Hrushi20]

Hey @MarkEWaite, incremental repack is failing. I'm getting task timeout error. Can you help me with that. I fixed all the other tests. Looking forward to getting this feature merged.

[Hrushi20]

Hey @MarkEWaite, I've fixed all the Unit test Issues. I ran a git rebase and the code is up to date with latest master. There are 2 spotbug issues, I am facing. Should I use the Spotbug flag to neglect such an issue? Looking forward to getting this merged.

[Hrushi20]

Hey @MarkEWaite, can we get this code merged?

[Hrushi20]

Hey! What are the steps to take to get this PR merged @MarkEWaite? Can I ignore the Spotbugs error?

[emericcolombe]

Hi @Hrushi20 thanks for this awesome feature ! Looking forward to using it in the next release.
@MarkEWaite can the spotbug error be ignored ?

[Hrushi20]

I'm ready to contribute and help in all way possible to get this feature merged and maintain it further.

[Hrushi20]

I sent multiple emails and reached out to the community multiple times. They just don't seem to respond to get this feature merged.

[emericcolombe]

@Hrushi20 Looks like the failing tests are legit.
You have 2 empty TODOs in the code:
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/open-tasks/modified/fileName.2040967631/source.05e34351-0bfc-4b54-a417-c7a3eddba773/#30
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/open-tasks/modified/fileName.1052819528/source.3ec1628f-39aa-4af8-8ef8-6f0eaf10f564/#5
And 2 java warnings:
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/spotbugs/modified/fileName.2040967631/source.f8568042-e6cd-4e2b-a0d6-b3221b4f88ea/#57
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/spotbugs/fileName.-313324747/source.cfa00caa-c76f-4def-b12c-005f1aac502e/#57

[Hrushi20]

@Hrushi20 Looks like the failing tests are legit.
You have 2 empty TODOs in the code:
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/open-tasks/modified/fileName.2040967631/source.05e34351-0bfc-4b54-a417-c7a3eddba773/#30
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/open-tasks/modified/fileName.1052819528/source.3ec1628f-39aa-4af8-8ef8-6f0eaf10f564/#5
And 2 java warnings:
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/spotbugs/modified/fileName.2040967631/source.f8568042-e6cd-4e2b-a0d6-b3221b4f88ea/#57
https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1277/168/spotbugs/fileName.-313324747/source.cfa00caa-c76f-4def-b12c-005f1aac502e/#57

Hey! Those todos can be removed. The TODO was to add date of file created.

I'm just facing issues with Spotbugs.

[Hrushi20]

Hey! Updated the code. Removed those todos. Only spotbugs issue.