Skip to content

Test with Java 17 in addition to Java 11 and Java 8 #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 5 commits into from
Apr 6, 2022
Merged

Test with Java 17 in addition to Java 11 and Java 8 #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9419f1
Test with Java 17 in addition to Java 11 and Java 8
MarkEWaite Apr 6, 2022
7686620
Remove argLine override to fix Java 17 build
MarkEWaite Apr 6, 2022
c8e4e1f
Actually test Java 17
MarkEWaite Apr 6, 2022
e711ad8
Remove unused source encoding setting
MarkEWaite Apr 6, 2022
6b8a319
Remove h3 from javadoc
MarkEWaite Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

buildPlugin(failFast: false,
configurations: [
[platform: 'linux', jdk: '11'],
[platform: 'windows', jdk: '8'],
[platform: 'linux', jdk: '17', jenkins: '2.342'],
[platform: 'linux', jdk: '11'],
[platform: 'windows', jdk: '8'],
])
2 changes: 0 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@
<revision>4.11.1</revision>
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<argLine>-Dfile.encoding=${project.build.sourceEncoding}</argLine>
<jenkins.version>2.289.1</jenkins.version>
<no-test-jar>false</no-test-jar>
<useBeta>true</useBeta>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/hudson/plugins/git/extensions/GitSCMExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public FilePath getWorkingDirectory(GitSCM scm, AbstractProject<?, ?> context, F
* the chosen revision and returning it) or manipulate the state of the working tree (such as
* running git-clean.)
*
* <h3>{@link #decorateRevisionToBuild(GitSCM, Run, GitClient, TaskListener, Revision, Revision)} vs {@link BuildChooser}</h3>
* <strong>{@link #decorateRevisionToBuild(GitSCM, Run, GitClient, TaskListener, Revision, Revision)} vs {@link BuildChooser}</strong>
* <p>
* {@link BuildChooser} and this method are similar in the sense that they both participate in the process
* of determining what commits to build. So when a plugin wants to control the commit to be built, you have
Expand Down