JENKINS-62285 Don't use browser alert for notifications and confirmation

src/main/resources/io/jenkins/plugins/folderauth/FolderAuthorizationStrategyManagementLink/index.jelly

@@ -3,6 +3,7 @@
     <l:layout permission="${app.ADMINISTER}" norefresh="true" title="${%title}">
         <st:include it="${app}" page="sidepanel.jelly" optional="true"/>
         <l:main-panel>
+            <script src="${rootURL}/plugin/folder-auth/js/notification.js"/>
             <script src="${rootURL}/plugin/folder-auth/js/addrole.js"/>
             <script src="${rootURL}/plugin/folder-auth/js/folders.js"/>
             <script src="${rootURL}/plugin/folder-auth/js/managesids.js"/>

src/main/webapp/js/addrole.js

@@ -7,7 +7,7 @@
 const addGlobalRole = () => {
     const roleName = document.getElementById('globalRoleName').value;
     if (!roleName || roleName.length < 3) {
-        alert('Please enter a valid name for the role to be added.');
+        showNotificationERROR('Please enter a valid name for the role to be added.');
         return;
     }
 
@@ -17,7 +17,7 @@ const addGlobalRole = () => {
     };
 
     if (response.permissions.length <= 0) {
-        alert('Please select at least one permission');
+        showNotificationERROR('Please select at least one permission');
         return;
     }
 
@@ -31,7 +31,7 @@ const addGlobalRole = () => {
 const addFolderRole = () => {
     const roleName = document.getElementById('folderRoleName').value;
     if (!roleName || roleName.length < 3) {
-        alert('Please enter a valid name for the role to be added');
+        showNotificationERROR('Please enter a valid name for the role to be added');
         return;
     }
 
@@ -42,12 +42,12 @@ const addFolderRole = () => {
     };
 
     if (!response.permissions || response.permissions.length <= 0) {
-        alert('Please select at least one permission');
+        showNotificationERROR('Please select at least one permission');
         return;
     }
 
     if (!response.folderNames || response.folderNames.length <= 0) {
-        alert('Please select at least one folder on which this role will be applicable');
+        showNotificationERROR('Please select at least one folder on which this role will be applicable');
         return;
     }
 
@@ -61,7 +61,7 @@ const addFolderRole = () => {
 const addAgentRole = () => {
     const roleName = document.getElementById('agentRoleName').value;
     if (!roleName || roleName.length < 3) {
-        alert('Please enter a valid name for the role to be added');
+        showNotificationERROR('Please enter a valid name for the role to be added');
         return;
     }
 
@@ -72,12 +72,12 @@ const addAgentRole = () => {
     };
 
     if (!response.permissions || response.permissions.length <= 0) {
-        alert('Please select at least one permission');
+        showNotificationERROR('Please select at least one permission');
         return;
     }
 
     if (!response.agentNames || response.agentNames.length <= 0) {
-        alert('Please select at least one agent on which this role will be applicable');
+        showNotificationERROR('Please select at least one agent on which this role will be applicable');
         return;
     }
 
@@ -100,10 +100,10 @@ const sendPostRequest = (postUrl, json) => {
 
     xhr.onload = () => {
         if (xhr.status === 200) {
-            alert('The role was added successfully');
-            location.reload(); // refresh the page
+            showNotificationOK('The role was added successfully');
+            //location.reload(); // refresh the page
         } else {
-            alert('Unable to add the role\n' + xhr.responseText);
+            showNotificationERROR('Unable to add the role\n' + xhr.responseText);
         }
     };
 

src/main/webapp/js/folders.js

@@ -13,7 +13,7 @@ const getFolders = () => {
     };
 
     xhr.onerror = () => {
-        alert(`Unable to get the list of folders: ${xhr.responseText}`);
+        showNotificationERROR(`Unable to get the list of folders: ${xhr.responseText}`);
     };
 };
 

src/main/webapp/js/managesids.js

@@ -21,16 +21,16 @@ function assignSid(roleType, roleName, sidInputBoxId) {
     request.open('POST', url);
     request.onload = () => {
         if (request.status === 200) {
-            alert('Sid added successfully.');
+            showNotificationOK('Sid added successfully.');
             location.reload();
         } else {
-            alert('Unable to remove the sid.' + request.responseText);
+            showNotificationERROR('Unable to remove the sid.' + request.responseText);
         }
 
     };
 
     request.onerror = () => {
-        alert('Unable to add the sid to the role: ' + request.responseText);
+        showNotificationERROR('Unable to add the sid to the role: ' + request.responseText);
     };
 
     // see addRole.js
@@ -59,15 +59,15 @@ function removeSid(roleType, roleName, sidInputBoxId) {
     request.open('POST', url);
     request.onload = () => {
         if (request.status === 200) {
-            alert('Sid removed successfully.');
+            showNotificationOK('Sid removed successfully.');
             location.reload();
         } else {
-            alert('Unable to remove the sid.' + request.responseText);
+            showNotificationERROR('Unable to remove the sid.' + request.responseText);
         }
     };
 
     request.onerror = () => {
-        alert('Unable to remove the sid from the role: ' + request.responseText);
+        showNotificationERROR('Unable to remove the sid from the role: ' + request.responseText);
     };
 
     // see addRole.js

src/main/webapp/js/notification.js

@@ -0,0 +1,16 @@
+function showNotification(message, options, reload = false) {
+    notificationBar.show(message, options);
+    if (reload) {
+        window.setTimeout(function () {
+            location.reload();
+        }, notificationBar.DELAY);
+    }
+}
+
+function showNotificationOK(message) {
+    showNotification(message, notificationBar.OK, true);
+}
+
+function showNotificationERROR(message) {
+    showNotification(message, notificationBar.ERROR);
+}