Update Spare Instance parameter to consider idle executors #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're using more than 1 executor per agent and the scheduling strategy spreads builds across the existing agents, we could end up scaling up many more agents than we need.
|
Could you add a test for this? |
|
I don't see any existing tests for this area of the code (unless I've missed something) and I'm not invested enough in this change right now to write a new test suite from scratch. If someone else wants to take on tests for this feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're using more than 1 executor per agent and the scheduling
strategy spreads builds across the existing agents, we could end up
scaling up many more agents than we need.