Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74907] Add validations when Jenkins is in FIPS mode #1010

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

jmdesprez
Copy link

PR to improve plugin's FIPS compliance. All the checks are centralized in FIPS140Utils to ensure consistency of error messages.

Bump of Jenkins is required to have access to FIPS140.useCompliantAlgorithms()

Testing done

See added unit tests. Here is also screenshots from the form validation:

image

image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

pom.xml Outdated Show resolved Hide resolved
@jmdesprez
Copy link
Author

I'm fixing the unit test

@fcojfernandez fcojfernandez changed the title [JENKINS-74907] Improve FIPS compliance [JENKINS-74907] Add validations when Jenkins is in FIPS mode Nov 26, 2024
@fcojfernandez fcojfernandez added the enhancement Feature additions or enhancements label Nov 26, 2024
@jmdesprez jmdesprez marked this pull request as draft November 26, 2024 15:48
@jmdesprez
Copy link
Author

It's not possible to tests this because of non-compliant dependencies. So I'm moving this PR to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature additions or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants