-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-74907] Add validations when Jenkins is in FIPS mode #1010
Draft
jmdesprez
wants to merge
18
commits into
jenkinsci:master
Choose a base branch
from
jmdesprez:JENKINS-74907
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to have access to jenkins.security.FIPS140
PereBueno
reviewed
Nov 26, 2024
I'm fixing the unit test |
Priya-CB
reviewed
Nov 26, 2024
fcojfernandez
changed the title
[JENKINS-74907] Improve FIPS compliance
[JENKINS-74907] Add validations when Jenkins is in FIPS mode
Nov 26, 2024
It's not possible to tests this because of non-compliant dependencies. So I'm moving this PR to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to improve plugin's FIPS compliance. All the checks are centralized in
FIPS140Utils
to ensure consistency of error messages.Bump of Jenkins is required to have access to
FIPS140.useCompliantAlgorithms()
Testing done
See added unit tests. Here is also screenshots from the form validation:
Submitter checklist
Link to relevant pull requests, esp. upstream and downstream changes