[JENKINS-34150] Fix hung Batch steps #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanoort
changed the title
Member
Author
|
Regression inexplicably triggered on some systems by #66 |
Member
Author
|
@reviewbybees |
abayer
approved these changes
Mar 8, 2018
svanoort
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix a regression JENKINS-50025 introduced in #66 -- a subtle issue that may revolve around a quirk of path handling in Windows.
This triggers symptoms matching JENKINS-34150.
After an hour of investigation with the user (results noted in ticket) and without an ability to easily reproduce the issue, I am backing out the previous change to the BatchScriptDurableTask.
Other components of #66 (the zero-length file check) should adequately ensure Windows coverage for JENKINS-25519, and I'd rather go back to a known-good version than risk a second regression. This version was tested with the user and confirmed to work correctly.