Skip to content

[JENKINS-25519] If unable to read exitStatus file then wait briefly and retry one more time to allow write to complete #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svanoort wants to merge 1 commit into from
Closed

[JENKINS-25519] If unable to read exitStatus file then wait briefly and retry one more time to allow write to complete #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/org/jenkinsci/plugins/durabletask/FileMonitoringTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,17 @@ private static class WriteLog extends MasterToSlaveFileCallable<Long> {
// TODO would be more efficient to allow API to consolidate writeLog with exitStatus (save an RPC call)
@Override public Integer exitStatus(FilePath workspace, Launcher launcher, TaskListener listener) throws IOException, InterruptedException {
FilePath status = getResultFile(workspace);
if (status.exists()) {
if (status.exists() && status.length() > 0) {
Copy link
Member

@jglick jglick Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this alone would fix the issue, right?

Copy link
Member Author

@svanoort svanoort Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, yes, if there's no bogus whitespace or other stuff in there.

try {
return Integer.parseInt(status.readToString().trim());
} catch (NumberFormatException x) {
throw new IOException("corrupted content in " + status + ": " + x, x);
LOGGER.log(Level.FINE, "Unable to parse exit code file, waiting briefly and retrying - file "+status+" error message: "+x.getMessage());
try {
Thread.sleep(100);
return Integer.parseInt(status.readToString().trim());
} catch (NumberFormatException nfe) {
throw new IOException("corrupted content in " + status + ": " + nfe, nfe);
}
}
} else {
return null;
Expand Down