-
Notifications
You must be signed in to change notification settings - Fork 96
[JENKINS-72436] sh step on z/OS with encoding set to UTF-8 hangs when trying to read jenkins-result.txt
#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
system property ibm.system.encoding
|
Test failures on linux due to docker container not ramping up properly. |
|
After looking at #28, #76 and #80 I believe that #28 and #76 have been superseded by #80 with a more general solution and should be considered obsolete. #28 has been a (my) first attempt in 2016 making pipelines work on z/OS nodes. #76 is only a kind of proof of concept far from being ready to merge. This PR #199 is a fix to the z/OS support introduced with PR #80. Some more background from our end: |
|
#201 has a possible solution for the issue (JENKINS-72488) causing the failure of checks of this PR. |
sh step on z/OS with encoding set to UTF-8 hangs when trying to read jenkins-result.txt
src/main/java/org/jenkinsci/plugins/durabletask/BourneShellScript.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/durabletask/BourneShellScript.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/durabletask/BourneShellScript.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
…ipt.java Co-authored-by: Jesse Glick <jglick@cloudbees.com>
|
@jglick , I applied all your requested changes. Doing it with two commits right after each other caused Jenkins to abort the build for the first commit (https://ci.jenkins.io/job/Plugins/job/durable-task-plugin/job/PR-199/7/) as it has been superseded by build for the second commit (https://ci.jenkins.io/job/Plugins/job/durable-task-plugin/job/PR-199/8/). Hence, github got not aware of all the review changes applied and claims one pending although it is in the code. |
jglick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From code inspection, should not affect other platforms, so 👍
Fixing JENKINS-72436
When running on z/OS always use the system's encoding for reading file jenkins-result.txt. System's encoding is provided in system property ibm.system.encoding.
No change in behavior for any other operating system.
Testing done
Successfully tested on a z/OS node the following pipeline:
Test pipeline output:
No automated tests for z/OS.