-
Notifications
You must be signed in to change notification settings - Fork 249
Add snapshot taker for special StandardUsernamePasswordCredentials impls
#327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jglick
merged 3 commits into
jenkinsci:master
from
jamesrobson-secondmind:add-username-pwd-snapshottaker
Jul 1, 2022
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
e331be4
Add snapshot taker for StandardUsernamePasswordCredentials
jamesrobson-secondmind 3ec0e9f
Special case snapshots for UsernamePasswordCredentialsImpl
jamesrobson-secondmind 69e3682
Ensure usernameSecret is set correctly in snapshots
jamesrobson-secondmind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
30 changes: 30 additions & 0 deletions
30
...java/com/cloudbees/plugins/credentials/impl/UsernamePasswordCredentialsSnapshotTaker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package com.cloudbees.plugins.credentials.impl; | ||
|
|
||
| import com.cloudbees.plugins.credentials.CredentialsSnapshotTaker; | ||
| import com.cloudbees.plugins.credentials.common.StandardUsernamePasswordCredentials; | ||
|
|
||
| import hudson.Extension; | ||
| import hudson.util.Secret; | ||
|
|
||
| @Extension | ||
| public class UsernamePasswordCredentialsSnapshotTaker extends CredentialsSnapshotTaker<StandardUsernamePasswordCredentials> { | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public Class<StandardUsernamePasswordCredentials> type() { | ||
| return StandardUsernamePasswordCredentials.class; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public StandardUsernamePasswordCredentials snapshot(StandardUsernamePasswordCredentials credentials) { | ||
| if (credentials instanceof UsernamePasswordCredentialsImpl) { | ||
| return credentials; | ||
| } | ||
| return new UsernamePasswordCredentialsImpl(credentials.getScope(), credentials.getId(), credentials.getDescription(), credentials.getUsername(), Secret.toString(credentials.getPassword())); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just in case other impls now implement this parameter as well.