Skip to content

bump parent pom #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jglick merged 2 commits into from
Jan 14, 2020
Merged

bump parent pom #132

jglick merged 2 commits into from
Jan 14, 2020

Conversation

@jetersen
Copy link
Member

@jetersen jetersen commented Jan 13, 2020 •
edited
Loading

blocking #133

jglick
jglick requested changes Jan 13, 2020
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Rule 5: org.apache.maven.plugins.enforcer.RequireUpperBounDeps failed with message:
 ​Failed while enforcing RequireUpperBoudDeps. The error(s) are [
 ​Require upper bound dependencies error for org.hamcrest:hamcrest-core:1. paths to dependency are:
 ​+-org.jenkins-ci.plugins:credentials:.3.1-rc732.ee813ca1e391
   ​+-org.xmlunit:mlunit-matchers:2.2.0
     ​+-org.amcret:hamcrest-core:1.3
 ​and
 ​+-org.jenkins-ci.plugins:credentials:.3.1-rc732.ee813ca1e391
   ​+-org.jenkins-ci.main:jenins-test-harness:2.57
     ​+-org.amcret:hamcrest-core:2.2
 ​and
 ​+-org.jenkins-ci.plugins:credentials:.3.1-rc732.ee813ca1e391
  ​+-junit:junit:4.12
     ​+-org.amcret:hamcrest-core:1.3
 ​and
 ​+-org.jenkins-ci.plugins:credentials:.3.1-rc732.ee813ca1e391
   ​+-org.jenkins-ci.main:jenins-test-harness:2.57
     ​+-org.hamcrest:amcrest-library:2.2
       ​+-org.amcest:hamcrest-core:2.2

@jetersen
Copy link
Member Author

jetersen commented Jan 13, 2020

all greenio :)

jglick
jglick approved these changes Jan 14, 2020
View reviewed changes
pom.xml
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>2.2</version>
Copy link
Member

@jglick jglick Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here, this is supposed to be pinned by the parent POM. I suspect some other dependency is throwing things off. Oh well, can be fixed up some other time.

@jglick jglick merged commit b03d6cc into jenkinsci:master Jan 14, 2020
@jetersen jetersen deleted the patch-1 branch January 14, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick approved these changes

Assignees

No one assigned

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jetersen @jglick