Skip to content

Conversation

@oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Jan 7, 2020

https://issues.jenkins-ci.org/browse/JENKINS-60661

This pull request adds capturing of authors from pull requests:

  • All commit authors are included. "committers" are not included
  • If GitHub REST API does not include GitHub ID, we query GitHub by email. At the moment it will unlikely help in any cases, but it will be useful for coauthors later.

Open Questions

Sample YAMLs

Common PR

  - type: rfe
    pull: 4245
    authors:
    - daniel-beck
    message: |-
      TODO fixup changelog:
      PR title: Update script-security to 1.65
      Proposed changelog:
      * Update bundled version of Script Security Plugin to 1.65

PR without GitHub author in the commit metadata (jenkinsci/jenkins#4225):

  - type: rfe
    pull: 4225
    issue: 59152
    authors:
    - 'TODO: Stephan Reiter (stephan.reiter@msab.com)'
    message: |-
      TODO fixup changelog:
      PR title: [JENKINS-59152] - Reduce the default process soft-kill timeout from 2 minutes to 5 seconds
      Proposed changelog:
      * [JENKINS-59152] Default soft-kill timeout reduced to 5 seconds

PR with multiple authors - Need to find one, but not so helpful

@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Jan 7, 2020
@oleg-nenashev oleg-nenashev changed the title [JENKINS-60663] - Capture pull request authors [JENKINS-60663] - Capture pull request authors and add them to notable changes Jan 7, 2020
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 99% of cases co-authors from GitHub will have very minor contributions due to how GitHub does suggested changes; would just do it manually in notable cases.

@oleg-nenashev
Copy link
Member Author

In 99% of cases co-authors from GitHub will have very minor contributions due to how GitHub does suggested changes; would just do it manually in notable cases.

Yes, I would also prefer to postpone that for now.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge. Thanks for doing it!

@oleg-nenashev oleg-nenashev merged commit 00b82be into jenkinsci:master Jan 7, 2020
@oleg-nenashev oleg-nenashev deleted the JENKINS-60663 branch January 7, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants