Skip to content

Conversation

@ampuscas
Copy link

supersedes #184

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ampuscas
Copy link
Author

@jmMeessen could you please approve this PR?
I have created this PR that supersedes #184 for merging master, fixing the conflicts and updating dependencies as the build was failing due to Maven enforcer rule

@basil
Copy link
Member

basil commented May 1, 2022

Suggest closing in favor of #200.

@jmMeessen
Copy link
Contributor

@ampuscas
Thanks for submitting your PR.

Does @basil 's PR #200 take into account all your update proposal? In other words, could you please review the conflicts and update the PR accordingly? Or let me know if it can be closed.

@basil
Copy link
Member

basil commented May 2, 2022

I do not think this PR should be merged now that PR #200 has been merged. The only change that remains in this PR after #200 is the bump of the Jenkins baseline to 2.332.x. While that is not necessarily a bad thing, I can't think of a reason why it is needed at the present time, and it effectively locks out users of older lines (including jenkinsci/bom) from receiving updates. If testing against recent cores is needed and what we already do in jenkinsci/bom is not sufficient, an additional branch could be added to this repository's Jenkinsfile.

@ampuscas
Copy link
Author

ampuscas commented May 5, 2022

@jmMeessen @basil thank you, I am closing this PR as the PR #200 solves the problems I was addressing with this PR

@ampuscas ampuscas closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants