Skip to content

Update PCT #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 9 commits into from
Feb 1, 2022
Merged

Update PCT #863

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a90eca5
Update PCT
timja Jan 29, 2022
684dc4b
Update failFast
timja Jan 29, 2022
6c08f64
Use snapshot
timja Jan 30, 2022
263847a
Merge branch 'try-update-bom' of github.com:timja/bom into try-update…
timja Jan 30, 2022
b1d113b
Update prep.sh
timja Jan 30, 2022
6111287
Merge branch 'master' into try-update-bom
timja Jan 31, 2022
70e82a8
Update
timja Jan 31, 2022
edcab60
Merge branch 'try-update-bom' of github.com:timja/bom into try-update…
timja Jan 31, 2022
ba4384a
Update failFast
timja Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion failFast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
true
false
7 changes: 4 additions & 3 deletions prep.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ do
done

# TODO find a way to encode this in some POM so that it can be managed by Dependabot
version=0.5.1-rc1066.9cfd30140d30 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/276
pct=$HOME/.m2/repository/org/jenkins-ci/tests/plugins-compat-tester-cli/${version}/plugins-compat-tester-cli-${version}.jar
[ -f $pct ] || $MVN dependency:get -Dartifact=org.jenkins-ci.tests:plugins-compat-tester-cli:${version}:jar -DremoteRepositories=https://repo.jenkins-ci.org/public/,https://repo.jenkins-ci.org/incrementals/ -Dtransitive=false
version=0.5.1-SNAPSHOT # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/344 (c9c684eab7e8de91650ad1c96ded6489c42910f1)
Copy link
Member

@jglick jglick Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to get jenkinsci/plugin-compat-tester#344 to pass tests—by ignoring stuff if necessary.

Copy link
Member Author

@timja timja Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, my last attempt of just reverting the PCT change that affected bom didn't go so well as there were other changes. Unless there's a simpler fix I'd probably just revert every PR in the last year =/.

pr-merge pain -.-, can't build an isolated PR

Not sure if I'll have the time to fix properly.

Copy link
Member

@jglick jglick Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. PCT needs a lot of work.

timestamp=0.5.1-20220130.152941-4
pct=$HOME/.m2/repository/org/jenkins-ci/tests/plugins-compat-tester-cli/${version}/plugins-compat-tester-cli-${timestamp}.jar
[ -f $pct ] || $MVN dependency:get -Dartifact=org.jenkins-ci.tests:plugins-compat-tester-cli:${timestamp}:jar -DremoteRepositories=https://repo.jenkins-ci.org/public/,https://repo.jenkins-ci.org/incrementals/ -Dtransitive=false
cp $pct target/pct.jar

# produces: target/{megawar-*.war,pct.jar,plugins.txt,lines.txt}