Remove redundant 2.332.x credentials dependency #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to duplicate the pin in the 2.332.x pom when it is already pinned with that version in the 2.346.x pom
jglick
added
chore
jglick
approved these changes
Nov 9, 2022
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>credentials</artifactId> | ||
| <version>1087.1089.v2f1b_9a_b_040e4</version> |
Member
There was a problem hiding this comment.
Hmm, pinned in #1065 but why?
I guess fine if CI passes.
Contributor
Author
There was a problem hiding this comment.
I've since learned that it was pinned at this version because that is the newest version supported on the 2.332.x line. This will need to remain.
Member
While you are here, we need to fix #1569. |
Credentials 1087.1089.v2f1b_9a_b_040e4 is the newest version supported on 2.332.1
MarkEWaite
changed the title
MarkEWaite
changed the title
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant 2.332.x credentials dependency
A credentials dependency was declared twice in the 2.332.x pom. One of the two dependencies declared the wrong version.
Remove the incorrect dependency.
#1564 (comment)