Skip to content

[JEP-230] [JENKINS-55582] Skip detached-plugins (was: pretest core with detached instance-identity) #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basil merged 7 commits into from
Jun 25, 2022
Merged

[JEP-230] [JENKINS-55582] Skip detached-plugins (was: pretest core with detached instance-identity) #1160

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
532ff3f
[JEP-230] [JENKINS-55582] Pretest core with detached `instance-identity`
jglick May 23, 2022
49fd17b
`!failFast`
jglick Jun 2, 2022
d9f4af8
Merge branch 'master' of https://github.com/jenkinsci/bom into instan…
jglick Jun 2, 2022
f9e79da
Merge branch 'master' of https://github.com/jenkinsci/bom into instan…
jglick Jun 8, 2022
ae921c6
See if leaving `WEB-INF/detached-plugins/*.hpi` in place fixes things
jglick Jun 8, 2022
0e6fefd
Merge remote-tracking branch 'origin/master' into instance-identity-j…
basil Jun 25, 2022
d309164
See if this works on current weekly
basil Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prep.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ for LINE in $LINEZ; do
echo '# nothing' >jenkins/split-plugins.txt
cp -r jenkins-for-test "megawar-${LINE}"
jar uvf megawar-$LINE/WEB-INF/lib/jenkins-core-*.jar jenkins/split-plugins.txt
rm -rfv megawar-$LINE/WEB-INF/detached-plugins megawar-$LINE/META-INF/*.{RSA,SF}
rm -rfv `# TODO delete all but instance-identity? megawar-$LINE/WEB-INF/detached-plugins` megawar-$LINE/META-INF/*.{RSA,SF}
Copy link
Member Author

@jglick jglick Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR this behavior dates to 6c00be1 because of jenkinsci/plugin-compat-tester#116 (comment) which was three years ago and I barely recall what the issue was.

mkdir "megawar-${LINE}/WEB-INF/plugins"
cp -rv test-classes/test-dependencies/*.hpi "megawar-${LINE}/WEB-INF/plugins"
cd "megawar-${LINE}"
Expand Down