Skip to content

[FIXED JENKINS-38664] Skip notification if root URL not defined #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenc merged 2 commits into from
Dec 18, 2017
Merged

[FIXED JENKINS-38664] Skip notification if root URL not defined #97

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f980a70
[FIXED JENKINS-38664] Skip notification if root URL not defined
stephenc Dec 18, 2017
69e0b50
[JENKINS-38664] Code review saves the day
stephenc Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import java.io.File;
import java.io.IOException;
import javax.annotation.CheckForNull;
import jenkins.model.JenkinsLocationConfiguration;
import jenkins.plugins.git.AbstractGitSCMSource;
import jenkins.scm.api.SCMHeadObserver;
import jenkins.scm.api.SCMRevision;
Expand All @@ -56,6 +57,12 @@ public class BitbucketBuildStatusNotifications {
private static void createStatus(@NonNull Run<?, ?> build, @NonNull TaskListener listener,
@NonNull BitbucketApi bitbucket, @NonNull String hash)
throws IOException, InterruptedException {
JenkinsLocationConfiguration cfg = JenkinsLocationConfiguration.get();
if (cfg == null || cfg.getUrl() == null) {
listener.getLogger().println(
"Can not determine Jenkins root URL. Commit status notifications are disabled until a root URL is"
+ " configured in Jenkins global configuration.");
Copy link
Member

@rsandell rsandell Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return statement?

}
String url;
try {
url = DisplayURLProvider.get().getRunURL(build);
Expand Down