-
Notifications
You must be signed in to change notification settings - Fork 364
[JENKINS-43507] Migrate Bitbucket Plugin to Traits #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 36 commits
43b5668
301f8d0
74b8531
b8f9be3
3530fca
dfd47ff
ee67e57
fd9e115
824dfd2
0e1e96a
88c4be3
933a75a
8f636d6
95aac94
50166af
a4c6bf3
71b6cae
0d083de
e0e18b2
b0c72b8
933aae0
255396d
4c80d63
e0875fa
9b71dd1
b5f8765
0874e73
23b61e5
c0cfdd7
e1b6547
103082f
107f747
ec0fc5b
6821f23
8b3b9eb
17541eb
3fa5f43
b9a3016
3c9bb0f
6f9a49f
7ecc02d
b307aaf
425d7bd
ee66530
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,144 +23,162 @@ | |
| ~ THE SOFTWARE. | ||
| --> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>plugin</artifactId> | ||
| <version>2.22</version> | ||
| <relativePath /> | ||
| </parent> | ||
| <parent> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>plugin</artifactId> | ||
| <version>2.22</version> | ||
| <relativePath /> | ||
| </parent> | ||
|
|
||
| <artifactId>cloudbees-bitbucket-branch-source</artifactId> | ||
| <version>2.1.3-SNAPSHOT</version> | ||
| <packaging>hpi</packaging> | ||
| <artifactId>cloudbees-bitbucket-branch-source</artifactId> | ||
| <version>2.2.0-SNAPSHOT</version> | ||
| <packaging>hpi</packaging> | ||
|
|
||
| <name>Bitbucket Branch Source Plugin</name> | ||
| <url>https://wiki.jenkins-ci.org/display/JENKINS/Bitbucket+Branch+Source+Plugin</url> | ||
| <description>Discover and build Bitbucket Cloud and Bitbucket Server pull requests and branches and send status notifications with the build result.</description> | ||
| <licenses> | ||
| <license> | ||
| <name>MIT License</name> | ||
| <url>http://opensource.org/licenses/MIT</url> | ||
| </license> | ||
| </licenses> | ||
| <name>Bitbucket Branch Source Plugin</name> | ||
| <url>https://wiki.jenkins-ci.org/display/JENKINS/Bitbucket+Branch+Source+Plugin</url> | ||
| <description>Discover and build Bitbucket Cloud and Bitbucket Server pull requests and branches and send status | ||
| notifications with the build result. | ||
| </description> | ||
| <licenses> | ||
| <license> | ||
| <name>MIT License</name> | ||
| <url>http://opensource.org/licenses/MIT</url> | ||
| </license> | ||
| </licenses> | ||
|
|
||
| <properties> | ||
| <jenkins.version>1.642.3</jenkins.version> | ||
| <scm-api.version>2.0.4</scm-api.version> | ||
| </properties> | ||
| <properties> | ||
| <jenkins.version>1.642.3</jenkins.version> | ||
| <scm-api.version>2.2.0-alpha-1</scm-api.version> | ||
| <git.version>3.4.0-alpha-1</git.version> | ||
| </properties> | ||
|
|
||
| <scm> | ||
| <connection>scm:git:git://github.com/jenkinsci/bitbucket-branch-source-plugin.git</connection> | ||
| <developerConnection>scm:git:git@github.com:jenkinsci/bitbucket-branch-source-plugin.git</developerConnection> | ||
| <url>https://github.com/jenkinsci/bitbucket-branch-source-plugin</url> | ||
| <tag>HEAD</tag> | ||
| </scm> | ||
| <scm> | ||
| <connection>scm:git:git://github.com/jenkinsci/bitbucket-branch-source-plugin.git</connection> | ||
| <developerConnection>scm:git:git@github.com:jenkinsci/bitbucket-branch-source-plugin.git</developerConnection> | ||
| <url>https://github.com/jenkinsci/bitbucket-branch-source-plugin</url> | ||
| <tag>HEAD</tag> | ||
| </scm> | ||
|
|
||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| <version>${scm-api.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>git</artifactId> | ||
| <version>2.6.5</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>mercurial</artifactId> | ||
| <version>1.58</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.codehaus.jackson</groupId> | ||
| <artifactId>jackson-jaxrs</artifactId> | ||
| <version>1.9.13</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>display-url-api</artifactId> | ||
| <version>0.2</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>branch-api</artifactId> | ||
| <version>2.0.6</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| <version>${scm-api.version}</version> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <version>1.10.19</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-core</artifactId> | ||
| <version>1.3</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>git</artifactId> | ||
| <version>2.6.5</version> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-multibranch</artifactId> | ||
| <version>2.11</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-aggregator</artifactId> | ||
| <version>1.15</version> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| <version>${scm-api.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>git</artifactId> | ||
| <version>${git.version}</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>mercurial</artifactId> | ||
| <version>2.0-alpha-1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.codehaus.jackson</groupId> | ||
| <artifactId>jackson-jaxrs</artifactId> | ||
| <version>1.9.13</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>display-url-api</artifactId> | ||
| <version>0.2</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>branch-api</artifactId> | ||
| <version>2.0.11-alpha-1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| <version>${scm-api.version}</version> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <version>1.10.19</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-core</artifactId> | ||
| <version>1.3</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>git</artifactId> | ||
| <version>${git.version}</version> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-multibranch</artifactId> | ||
| <version>2.11</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-aggregator</artifactId> | ||
| <version>1.15</version> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| </dependencies> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there some real change in dependencies or is it all formatting?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/53/files?w=1 says only version bumps in scm-api, branch-api, git and mercurial plugins |
||
|
|
||
| <repositories> | ||
| <repository> | ||
| <id>repo.jenkins-ci.org</id> | ||
| <url>http://repo.jenkins-ci.org/public/</url> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>repo.jenkins-ci.org</id> | ||
| <url>http://repo.jenkins-ci.org/public/</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
| <repositories> | ||
| <repository> | ||
| <id>repo.jenkins-ci.org</id> | ||
| <url>http://repo.jenkins-ci.org/public/</url> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>repo.jenkins-ci.org</id> | ||
| <url>http://repo.jenkins-ci.org/public/</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.jenkins-ci.tools</groupId> | ||
| <artifactId>maven-hpi-plugin</artifactId> | ||
| <configuration> | ||
| <compatibleSinceVersion>2.0.0</compatibleSinceVersion> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.jenkins-ci.tools</groupId> | ||
| <artifactId>maven-hpi-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>generate-taglib-interface</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| <configuration> | ||
| <compatibleSinceVersion>2.0.0</compatibleSinceVersion> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 2.2.0-SNAPSHOT to match what is in master?