JENKINS-39392 don't disable pull request scanning for bitbucket server instances#24
Closed
mrooney wants to merge 2 commits intojenkinsci:masterfrom
Closed
JENKINS-39392 don't disable pull request scanning for bitbucket server instances#24mrooney wants to merge 2 commits intojenkinsci:masterfrom
mrooney wants to merge 2 commits intojenkinsci:masterfrom
Conversation
|
We have this problem too, and I'm currently running a custom version of the plugin with that I think ideally it should be configurable when creating a bitbucket branch source folder. UPDATE: Sounds like #9 implements an option for enabling / disabling PR building |
amuniz
reviewed
Nov 22, 2016
|
|
||
| String branchNameForExclusionTest = branchName; | ||
| if (pr != null) { | ||
| branchNameForExclusionTest = String.format("PR-%s %s", pr.getId(), pr.getSource().getBranch().getName()); |
Member
There was a problem hiding this comment.
I don't think this is related to the fix explained in the description, but useful I think.
Member
Author
There was a problem hiding this comment.
Apologies, you are right @amuniz, I didn't realize future commits to my fork updated the PR. This is a fix to allow "PR-*" branch matching to work (https://issues.jenkins-ci.org/browse/JENKINS-36890). Would you like me to file this as a separate PR?
|
👍 |
Member
|
superseded by #53 |
fengxx
pushed a commit
to fengxx/bitbucket-branch-source-plugin
that referenced
this pull request
Mar 13, 2018
…s-descriptor-api Remove useless MultiBranchProjectDescriptor#getSCMDescriptors() API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://issues.jenkins-ci.org/browse/JENKINS-39392:
Currently the plugin checks if the repo is public, and doesn't allow building PRs, "Skipping pull requests for public repositories." While I assume this is for security purposes for Bitbucket.org, it is a problematic limitation for private Bitbucket Server instances that use a PR-based flow and have the repo "Public", which only means it can be viewed and cloned. Only authenticated users can push and create pull requests and we need to be able to discover and test these effectively private pull requests.
I'm not sure if this behavior is intentional even for Bitbucket Server instances; if so, there should be a configuration option to enable this or, if "PR*" is in the branch pattern, it should be enabled since it is specifically requested.