Skip to content

Add a check to avoid JENKINS-38664 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hogarth-sv wants to merge 1 commit into from
Closed

Add a check to avoid JENKINS-38664 #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,14 @@
import hudson.scm.SCMRevisionState;
import java.io.File;
import java.io.IOException;
import java.net.URI;
import java.lang.IllegalStateException;
import jenkins.scm.api.SCMHead;
import jenkins.scm.api.SCMSource;
import jenkins.scm.api.SCMSourceOwner;
import org.jenkinsci.plugins.displayurlapi.DisplayURLProvider;


/**
* This class encapsulates all Bitbucket notifications logic.
* {@link JobCompletedListener} sends a notification to Bitbucket after a build finishes.
Expand All @@ -69,7 +72,11 @@ private static void createBuildCommitStatus(@NonNull Run<?,?> build, @NonNull Ta
String url;
try {
url = DisplayURLProvider.get().getRunURL(build);
} catch (IllegalStateException e) {
URI testURI = new URI(url);
if (!testURI.getHost().contains(".")) {
throw new IllegalStateException("Jenkins RootURL not a FQDN");
}
} catch (IllegalStateException|java.net.URISyntaxException e) {
listener.getLogger().println("Can not determine Jenkins root URL. Commit status notifications are disabled until a root URL is configured in Jenkins global configuration.");
return;
}
Expand Down