Skip to content

Create a ChangeRequestAction so the CHANGE_ID is filled when building#13

Closed
Eernie wants to merge 4 commits intojenkinsci:masterfrom
Eernie:feature/MoreInformationForPRBuilds
Closed

Create a ChangeRequestAction so the CHANGE_ID is filled when building#13
Eernie wants to merge 4 commits intojenkinsci:masterfrom
Eernie:feature/MoreInformationForPRBuilds

Conversation

@Eernie
Copy link
Contributor

@Eernie Eernie commented Jul 4, 2016

When building a PR we can fill the CHANGE_ID by adding an action to the SCMHead.
I tried to make it somewhat identical to the Github version

@reviewbybees

… a PR.

Also create a more descriptive name for the build. Being : PR-[ID]: [PR.title]
@ghost
Copy link

ghost commented Jul 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

import java.util.ArrayList;
import java.util.List;

public class PullrequestSCMHead extends SCMHeadWithOwnerAndRepo {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before messing around with these classes, it might be wise to take into account JENKINS-36283, which would probably involve changing the representation of heads and/or revisions. At least it did in the case of the analogous jenkinsci/github-branch-source-plugin#60.

@nickbroon
Copy link

👍

@josh-burton
Copy link

would love this merged

@Eernie
Copy link
Contributor Author

Eernie commented Sep 17, 2016

I'm closing this PR cause it will be obsolete after merging #19 .

@Eernie Eernie closed this Sep 17, 2016
fengxx pushed a commit to fengxx/bitbucket-branch-source-plugin that referenced this pull request Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants