Skip to content

Use CredentialsProvider.findCredentialByIdInItem #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nfalco79 merged 8 commits into from
Jan 16, 2026
Merged

Use CredentialsProvider.findCredentialByIdInItem #1163

nfalco79 merged 8 commits into from
Jan 16, 2026
+19 −21

Conversation

@jglick
Copy link
Member

@jglick jglick commented Jan 7, 2026

@jglick
Copy link
Member Author

jglick commented Jan 7, 2026

@nfalco79 f447eed seems to have broken tests. I would recommend making all changes via PR automerge, even if you consider yourself the sole plugin maintainer.

@nfalco79
Copy link
Member

nfalco79 commented Jan 8, 2026

I would recommend making all changes via PR automerge, even if you consider yourself the sole plugin maintainer.

you're right but I'm a lazy person inside

@jglick jglick marked this pull request as ready for review January 12, 2026 17:52
@nfalco79 nfalco79 merged commit 2d3efda into jenkinsci:master Jan 16, 2026
17 checks passed
@jglick jglick deleted the byId branch January 16, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtnord jtnord jtnord approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jglick @nfalco79 @jtnord