Skip to content

Conversation

@jetersen
Copy link
Member

blocking #14

@chriskilding
Copy link
Contributor

When I tried using v3.55 in my username/password bug fix branch, some of the tests in org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyTestSuite became flaky. Sometimes they failed with a socket read timeout, sometimes not. I don't know the cause, but rolling back to 3.50 stopped the failures.

As a result I don't think we can adopt v3.55 at the moment.

@jetersen
Copy link
Member Author

Disable the flaky test?

@chriskilding
Copy link
Contributor

chriskilding commented Jan 16, 2020

It was a test in org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyTestSuite (but didn't say which one). The stack trace had something about the HtmlUnit WebClient in it. Unfortunately the build history was deleted so I can't retrieve the exact stack trace.

@jetersen
Copy link
Member Author

There were breaking changes in the HtmlUnit library so that makes sense. That means we should fix them not ignore the problem.

@jetersen
Copy link
Member Author

@chriskilding this should be fixed in newer version: https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-3.56

@chriskilding
Copy link
Contributor

chriskilding commented Jan 20, 2020

There are some extra dependencies that have to be pinned to satisfy the Maven enforcer plugin. I did some work on identifying them in #10 so will need to copy some of that work into your PR. I encountered some noclassdeffound errors when doing that, which stayed hidden till runtime, so could you combine your dependency bumping PRs into #14? Then we can test all the changes together.

@chriskilding
Copy link
Contributor

closing in favour of #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants