Skip to content

Conversation

@meiswjn
Copy link
Contributor

@meiswjn meiswjn commented Apr 20, 2022

This PR bumps the version of:

  • Plugin Framework
  • Jenkins Core
  • BOM

It also pins the version of the Credentials plugin to the latest release as required for #68

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@meiswjn
Copy link
Contributor Author

meiswjn commented May 6, 2022

I had a look at the failing test cases. Bumping Caffeine fixed one issue, but now another remains. I will be gone for a few weeks and not sure if I can check in the meantime. As I am not that deep in frontend testing, I appreciate contributions!

@PierreBtz
Copy link
Contributor

@meiswjn I took the liberty of fixing the compilation error and the test error.

@PierreBtz PierreBtz merged commit 42b5df8 into jenkinsci:master May 12, 2022
@meiswjn
Copy link
Contributor Author

meiswjn commented May 13, 2022

Thanks! I was struggling with figuring out why the button was still disabled, apparently you fixed it by waiting for some JS. I am wondering: How did you find out about this? Did you just know it from experience or somehow debugged the frontend components? Would be happy to learn about this.

@meiswjn meiswjn deleted the feature/bump-version branch May 13, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants