Update dependencies, use OutboundAgent for tests
#652
Conversation
* Bump baseline and dependencies * Replace docker-fixtures with testcontainers * Cleanup
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>sso</artifactId> | ||
| <!-- Not apparently packaged as a plugin, but anyway used only for developer testing: --> |
| public void smokes() throws Exception { | ||
| ArtifactManagerTest.artifactArchiveAndDelete(j, new JCloudsArtifactManagerFactory(new MockBlobStore()), false, null); | ||
| ArtifactManagerTest.artifactStashAndDelete(j, new JCloudsArtifactManagerFactory(new MockBlobStore()), false, null); | ||
| assumeFalse("Does not work when Dockerized since the mock server is inaccessible from the container", DockerClientFactory.instance().isDockerAvailable()); |
There was a problem hiding this comment.
Replacement API does not have a version which declines to start a container when it could, which this test would need. Not much of a concern since this is a test facility used only by NetworkTest anyway.
There was a problem hiding this comment.
Thanks for this change. I'm seeing failures of the MockBlobStoreTest on the weekly line of the plugin BOM when trying to add the 2.516.x line and remove the 2.479.x line. The failure is visible in this check and in the matching ci.jenkins.io job. The failure message is:
java.lang.NoSuchMethodError: 'void org.jenkinsci.plugins.workflow.ArtifactManagerTest.artifactArchiveAndDelete(org.jvnet.hudson.test.JenkinsRule, jenkins.model.ArtifactManagerFactory, boolean, org.jenkinsci.test.acceptance.docker.DockerImage)'
at io.jenkins.plugins.artifact_manager_jclouds.MockBlobStoreTest.smokes(MockBlobStoreTest.java:44)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:648)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at java.base/java.lang.Thread.run(Thread.java:1583)
I can duplicate that failure in a local run of the plugin BOM with the command:
PLUGINS=artifact-manager-s3 LINE=weekly TEST=MockBlobStoreTest bash ./local-test.sh
I've confirmed that an incremental build of artifact-manager-s3 (including this change) passes the plugin BOM with the same command.
Would you be willing to release a new version of artifact-manager-s3 so that the 2.516.x release line can be added to the plugin BOM?
The pull request that needs the new release of artifact-manager-s3 is:
There was a problem hiding this comment.
@MarkEWaite sorry, I did not think of that at the time. https://github.com/jenkinsci/artifact-manager-s3-plugin/releases/tag/949.v2567c4c52d79
4 participants
#648 extended with jenkinsci/ssh-agents-plugin#607 / jenkinsci/workflow-api-plugin#416.