Skip to content

fix jcasc test harness #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 2 commits into from
Jan 14, 2020
Merged

fix jcasc test harness #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38dde87
fix jcasc test harness
jetersen Jan 13, 2020
7f9cad8
Merge branch 'master' into fix/jcasc-test-harness
jetersen Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
<tag>HEAD</tag>
</scm>

Copy link
Member

@jglick jglick Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid gratuitous diff hunks.

Copy link
Member Author

@jetersen jetersen Jan 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid gratuitous whitespace hunks 🗡 🤣

Copy link
Member

@jglick jglick Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the trailing spaces are unwanted, but if you feel the urge to clean up things like that it is best to do it in a separate PR explicitly claiming to have no semantic effect.

<properties>
<jenkins.version>2.60.3</jenkins.version>
<java.level>8</java.level>
<jcasc.version>1.30</jcasc.version>
<jcasc.version>1.35</jcasc.version>
</properties>

<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
Expand All @@ -56,10 +56,9 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.jenkins</groupId>
<artifactId>configuration-as-code</artifactId>
<groupId>io.jenkins.configuration-as-code</groupId>
<artifactId>test-harness</artifactId>
<version>${jcasc.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down