Remote console note test coverage & fixes #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…si-random execution order.
jglick
changed the title
dwnusbaum
approved these changes
Nov 1, 2018
Member
dwnusbaum
left a comment
dwnusbaum
left a comment
There was a problem hiding this comment.
Great to get the additional test coverage!
Member
|
@dwnusbaum You seem to know what you're doing and be working for cloudbees. Want to help out with the plugin a bit? I think we could use an active maintainer, maybe someone to make the next release. |
Member
|
@dblock I can help you with the next release if needed, but unfortunately I cannot commit to being an active maintainer. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the test coverage I proposed in #128, and fixes some straightforward cases that are now tested.
Subsumes #129, without which input text lacking a final newline would not be sent at all, unless
printlnandflushwere called, at which point the result string would contain an extra newline.