Skip to content

Adapt credentials plugin for cards #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 3 commits into from
Dec 27, 2025
Merged

Adapt credentials plugin for cards #2563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cedcccf
Adapt credentials plugin for cards
timja Dec 20, 2025
315ecc9
Fix spotless
timja Dec 20, 2025
1ad78b0
Discard changes to pom.xml
timja Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/main/java/org/jenkinsci/test/acceptance/plugins/credentials/ManagedCredentials.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,16 @@ public Control checkSystemPage(String name) {
* Check if the given credential is part of the domain.
*/
public Control checkIfCredentialsExist(String name) {
By xpath = by.xpath("//a[@title='" + name + "']");
if (getElement(xpath) == null) {
// post credentials-2.3.2
xpath = by.xpath("//td[contains(text(),'" + name + "')]");
}
By xpath = by.xpath("//td[contains(text(),'" + name + "')] | //a[contains(text(), '" + name + "')]");
return control(xpath);
}

/**
* Find the href of the associted
*/
public String credentialById(String name) {
By xpath = by.xpath("//a[@title='" + name + "']");
if (getElement(xpath) == null) {
// post credentials-2.3.2
xpath = by.xpath("//td[contains(text(),'" + name + "')]/parent::tr//a");
}
By xpath = by.xpath("//td[contains(text(),'" + name + "')]/parent::tr//a | //span[contains(text(),'" + name
+ "')]/parent::div/parent::div//a");
return control(xpath).resolve().getAttribute("href");
}
}
2 changes: 1 addition & 1 deletion src/test/java/core/CredentialsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class CredentialsTest extends AbstractJUnitTest {
private static final String CRED_DOMAIN = "mydomain";
private static final String CRED_USER = "user";
private static final String CRED_PWD = "password";
private static final String CRED_DESCR = "descr";
private static final String CRED_DESCR = "My-super-unique-description";
Copy link
Member Author

@timja timja Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if the tests used ID for locating the credentials but since its not I was a bit worried that this could end up not being unique enough so I just made it more specific, can drop this though.


@Test
@WithPlugins("ssh-credentials")
Expand Down