update go version to v1.19.2 #34
Conversation
|
Hi @amarps. Thanks for your PR. I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
Makefile
Outdated
| @@ -13,7 +13,7 @@ ORG := jenkins-x | |||
| ORG_REPO := $(ORG)/$(NAME) | |||
| RELEASE_ORG_REPO := $(ORG_REPO) | |||
| ROOT_PACKAGE := github.com/$(ORG_REPO) | |||
| GO_VERSION := 1.18.4 | |||
| GO_VERSION := 1.19.2 | |||
There was a problem hiding this comment.
Please change this to: https://github.com/jenkins-x/jx/blob/d06edf36217af6eb6ffd7a209245933dabd4cdb3/Makefile#L18
The go version is inferred from the underlying docker image and so this does not help in any sense. On the contrary, it can lead to wrong go version being included in the binary.
I will update the docs around updating go versions.
|
@amarps I have added the hacktoberfest label to this repo. I have one minor comment, once you change that, it should be good to merge. Thanks for the contribution :) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitm123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related to #33
Hi, if you don't mind I would be happy if this repo have hacktoberfest topic so my PR will be counted on hacktoberfest.