Skip to content

Conversation

@jglick
Copy link
Contributor

@jglick jglick commented Jul 28, 2022

Description

jenkinsci/bom#1336 (comment)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jglick jglick requested a review from a team as a code owner July 28, 2022 02:43
@halkeye halkeye enabled auto-merge (squash) July 28, 2022 02:46
@halkeye halkeye merged commit 35ee8c8 into jenkins-infra:master Jul 28, 2022
@jglick jglick deleted the patch-1 branch July 28, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants