Add recipe to migrate commons-lang usage to JDK APIs

[s4chinjha]

Fixes #1542

This PR adds a new recipe to help migrate commons-lang usage to standard JDK APIs using OpenRewrite.

What I did

• Added a new recipe MigrateCommonsLangToJdkApi in recipes.yml
• Reused existing OpenRewrite recipes instead of writing custom logic
• Added the required dependency (rewrite-apache) for these recipes
• Added a test to verify the transformation works
• Updated validate_metadata.py to include the new migration ID

The recipe replaces common StringUtils usages with equivalent JDK methods like Objects.toString and null-safe checks.

---

Testing

• Added a test case in DeclarativeRecipesTest
• Verified transformations like:
  • StringUtils.defaultString → Objects.toString
  • StringUtils.isEmpty → JDK checks
• Ran the specific test:
  mvn -pl plugin-modernizer-core -Dtest=DeclarativeRecipesTest#migrateCommonsLangToJdkApi test
• Ran full build:
  mvn clean install

All tests passed successfully.

---

Checklist

• Working from a feature branch
• Clear PR title and description
• Linked the issue
• Added test for the change

[jonesbusy]

Can you add minimal PR title and body template? It's more user friendly. You can get inspired from commons land 2 to 3 recipe.

Are all the OpenRewrite Recipes for Commons Lang to JDK added?

No need test for them, they can be added to the list. It's just to confirm the recipe is available on the declarative recipe collection.

PR looks already in good shape!

[s4chinjha]

Thanks for the review!

I’ve made the changes:

• Added PR title and body like other recipes
• Marked them with skip-verification so tests don’t fail
• Kept the main recipe only for commons-lang to JDK changes

I used existing OpenRewrite recipes instead of writing custom code.

Let me know if anything else needs to be fixed 🙂

[jonesbusy]

Last change is incorrect, we don't generate extra files. Please use JTE like other recipes and provide test for TemplateUtils.

Ideally I would like to see a dry-run change for for a plugin that need to be transformed

[jonesbusy]

Some examples

jenkinsci/naginator-plugin#196
jenkinsci/postbuildscript-plugin#281
jenkinsci/view-job-filters-plugin#116
jenkinsci/groovy-plugin#106
jenkinsci/aws-credentials-plugin#325

Also the skip-verification is needed on the new recipe. We want to ensure that the plugin compile before pushing a PR

[s4chinjha]

Thanks for the feedback. I’m working on the changes as suggested and will update the PR soon.

[jonesbusy]

Sure thanks. I think we can safely include all those recipes: https://docs.openrewrite.org/recipes/apache/commons/lang

[jonesbusy]

Why closing the PR?

[s4chinjha]

Hi @jonesbusy,

Sorry for closing the PR by mistake. I’m still working on the changes currently validating the recipe with dry-run on real plugins and updating tests as suggested.

I’ll reopen it once everything is ready.

Thanks!

[s4chinjha]

I’m currently looking into the reasons why the checks are failing. I’ll fix the issues and push an update shortly.

[jonesbusy]

Sure. Only replaceLibrariesByApiPluginWithBom is expected to fail.

I will disable it on main branch

[jonesbusy]

#1601

[s4chinjha]

I’ve addressed the feedback, fixed the issues, and updated the recipe configuration. The branch has also been rebased on the latest main. Please take another look @jonesbusy

[jonesbusy]

Thanks! LGTM