Skip to content

Conversation

@daniel-beck
Copy link
Contributor

Supports jenkinsci/jenkins#4683. Not needed without that, so best for merging to be held off given the review hell that PR is in right now.

@daniel-beck daniel-beck requested a review from a team as a code owner July 16, 2020 07:55
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"starting-processes" might be a bit confusing taking the link. Should it be "starting-daemon-processes" or so?

On a side note, it will need an update once #3364 is integrated

@daniel-beck
Copy link
Contributor Author

Should it be "starting-daemon-processes" or so?

Not really, the redirect just isn't optimal right now, but I don't think we have more appropriate existing docs.

@timja timja removed the on-hold label Jul 19, 2020
@timja
Copy link
Member

timja commented Jul 19, 2020

Is this ready to go @daniel-beck ?

@daniel-beck daniel-beck merged commit 1f66549 into jenkins-infra:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants