cap max segments #293
Merged
cap max segments #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283.
In the 90 degree case, the wiper algorithm adds a point which is way outside of the bounds of the machine (e.g, x: 8000000000, y: 0). If an effect is added that calls subsample to break up long lines, this particular case results in an extremely high number of additional points being added, which overwhelms the browser.
I was unable to figure out how to modify this algorithm to sensibly clip the line. Instead, I modified subsample to cap the number of segments into which any given line can be divided. This seems to work well, and does not noticeably change the visible pattern. Please scrutinize.