Skip to content

#5 Bugfix/enable js auto form send #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#5 Bugfix/enable js auto form send #6

wants to merge 2 commits into from

Conversation

@ivang7
Copy link

@ivang7 ivang7 commented Mar 10, 2019 •
edited
Loading

Исправление #5

  • Добавил к выдаче HTTP 2 недостающих скрипта
  • В HTML файле исправил первый тег (</html> на <html>) и добавил загрузку jquery скрипта

@chupocro
Copy link

chupocro commented Jun 25, 2020

When looking the served HTML in the browser the opening <html> tag (after removing the slash) is marked as an error because of the missing doctype before the <html> tag:

<!DOCTYPE html>

But after inserting the doctype the CSS no longer works (loading failed for /js/bootstrap.min.js) because of:

AsyncWebServerResponse *response = request->beginResponse_P(200, F("text/plain"), bootstrap_css, bootstrap_css_len);

The MIME type has to be "text/css", then everything works even with the doctype.

BTW, what version of Bootstrap is used? It is 50% smaller than the current version. Is that some old version or was it stripped down manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivang7 @chupocro