-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Sun and Moon texture handling + Realistic textures #127
Conversation
halo is pretty visible at night. and also it makes some kind of cool effect on clouds at daytime. |
By before I meant with the vanilla textures |
Also I remember seeing one or two people were talking about how the sun produces an absolutely blinding amount of light (which I agree with), so I tried to fix that without ruining how it looks |
And again, I think this is worth it for the new moon textures, as the pixelated moon can be jarring with how realistic the water and everything else looks |
I've updated the initial screenshots to reflect my recent changes |
I still think it will be better to make big but not so bright halo. It will mimic blooming effect |
and again "before" screenshots are not showing how it was actually looking before |
I will try this tomorrow, although I definitely wouldn't be if possible for it to be the size it was before without the sun and moon's filesize becoming completely ridiculous |
Changed it :v |
vanilla texture is not that big. and I prefer vanilla one because changing textures is texture artists task. so in a conclusion I think its better to leave all as it was before but decrease halo intencity. |
The filesizes ended up being smaller than I expected due to most of the image being empty space, so you'll be glad to know that a large halo is still possible with new textures |
Pretty much every shader in existence changes the way the sun looks; We are the outlier here. Also that point is kind of made irrelevant by the fact that we changed basically every single block texture to implement normal and spec maps :P Also yeah I worked out the halo, it should look how it did before in terms of size, although less bright because it was way too much before |
technically only thing we need is to sample sun/moon texture only in center of a sun/moon plane and programmelly draw a hall around it |
I don't like big amount of empty space in sun/moon textures too |
I'm not really familiar enough with GLSL to do that, so you'll have to work that out |
I think something between current intencity and "before" intencity will be ideal |
I think this is bright enough |
Do you want me to do another poll -_- |
I want vanilla sun and moon texture :-D and just a bit brighter halo (idk maybe 25 - 50% brighter) |
6d47468
to
d996efc
Compare
bc23f89
to
7cf0157
Compare
ALGTM. Gonna check it on my phone and merge |
Is this still happening or? |
sorry im just trying to find a minute to do this. University and work takes a lot of time :-( |
This fixes the issue where the sun texture needed to be really small otherwise it would be absolutely massive in-game
I also added some realistic textures for the sun and moon to better fit the overall vibe of the shader.
Before:


After: