Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Sun and Moon texture handling + Realistic textures #127

Merged
merged 12 commits into from
Apr 28, 2021

Conversation

OpenSauce04
Copy link
Contributor

@OpenSauce04 OpenSauce04 commented Apr 8, 2021

This fixes the issue where the sun texture needed to be really small otherwise it would be absolutely massive in-game
I also added some realistic textures for the sun and moon to better fit the overall vibe of the shader.

Before:
114122302-d14e5e80-9911-11eb-8c48-62b5bf17a48f.png
114122281-c98eba00-9911-11eb-8a94-291d9bee95e5.png

After:

image
image

@jebbyk
Copy link
Owner

jebbyk commented Apr 9, 2021

nah, this was before
Screenshot_20210409-085805
Screenshot_20210409-085754

@jebbyk
Copy link
Owner

jebbyk commented Apr 9, 2021

halo is pretty visible at night. and also it makes some kind of cool effect on clouds at daytime.

@OpenSauce04
Copy link
Contributor Author

By before I meant with the vanilla textures
I think that my optimization caused some issues as technically the sun and moon are taking up the entirety of the texture instead of only a tiny spot in the middle, but I moved it (the sun and moon) really far away to make up for the size

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 9, 2021

Also I remember seeing one or two people were talking about how the sun produces an absolutely blinding amount of light (which I agree with), so I tried to fix that without ruining how it looks
Also, the moon just doesn't look like that irl, there is way too much glow
Personally I think it looks better this way, but it's your call at the end of the day

@OpenSauce04
Copy link
Contributor Author

And again, I think this is worth it for the new moon textures, as the pixelated moon can be jarring with how realistic the water and everything else looks
The sun was less of an issue because you couldn't even see it most of the time

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 9, 2021

The majority of the server seems to agree too (from yesterday's poll)
image
At the end of the day we could even try to re-implement the glow later on

@OpenSauce04
Copy link
Contributor Author

Also the sunsets look much cooler imo
Screenshot_20210409-171400_Minecraft.jpg

@OpenSauce04 OpenSauce04 deleted the Better-Sun-Moon-Textures branch April 10, 2021 11:09
@OpenSauce04 OpenSauce04 restored the Better-Sun-Moon-Textures branch April 10, 2021 11:10
@OpenSauce04 OpenSauce04 reopened this Apr 10, 2021
@OpenSauce04
Copy link
Contributor Author

I've updated the initial screenshots to reflect my recent changes

@jebbyk
Copy link
Owner

jebbyk commented Apr 12, 2021

I still think it will be better to make big but not so bright halo. It will mimic blooming effect

@jebbyk
Copy link
Owner

jebbyk commented Apr 12, 2021

and again "before" screenshots are not showing how it was actually looking before

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 12, 2021

I still think it will be better to make big but not so bright halo. It will mimic blooming effect

I will try this tomorrow, although I definitely wouldn't be if possible for it to be the size it was before without the sun and moon's filesize becoming completely ridiculous
I can make it a bit bigger though, perhaps half way between how it is now and how it used to be?

@OpenSauce04
Copy link
Contributor Author

and again "before" screenshots are not showing how it was actually looking before

Changed it :v

@jebbyk
Copy link
Owner

jebbyk commented Apr 13, 2021

I still think it will be better to make big but not so bright halo. It will mimic blooming effect

I will try this tomorrow, although I definitely wouldn't be if possible for it to be the size it was before without the sun and moon's filesize becoming completely ridiculous
I can make it a bit bigger though, perhaps half way between how it is now and how it used to be?

vanilla texture is not that big. and I prefer vanilla one because changing textures is texture artists task. so in a conclusion I think its better to leave all as it was before but decrease halo intencity.

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 13, 2021

vanilla texture is not that big. and I prefer vanilla one because changing textures is texture artists task. so in a conclusion I think its better to leave all as it was before but decrease halo intencity.

Well I mean everyone else prefers the new ones
image
besides this isn't stopping other texture artists from just changing this to something else, or even the vanilla one

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 13, 2021

The filesizes ended up being smaller than I expected due to most of the image being empty space, so you'll be glad to know that a large halo is still possible with new textures

@jebbyk
Copy link
Owner

jebbyk commented Apr 13, 2021

vanilla texture is not that big. and I prefer vanilla one because changing textures is texture artists task. so in a conclusion I think its better to leave all as it was before but decrease halo intencity.

Well I mean everyone else prefers the new ones
image
besides this isn't stopping other texture artists from just changing this to something else, or even the vanilla one

we are making shader, not the texture pack. that is why I don't want to change vanilla textures. I have an idea how to keep really vanilla texture without big amount of empty space btw. and also keep hallo to

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 13, 2021

we are making shader, not the texture pack. that is why I don't want to change vanilla textures. I have an idea how to keep really vanilla texture without big amount of empty space btw. and also keep hallo to

Pretty much every shader in existence changes the way the sun looks; We are the outlier here. Also that point is kind of made irrelevant by the fact that we changed basically every single block texture to implement normal and spec maps :P

Also yeah I worked out the halo, it should look how it did before in terms of size, although less bright because it was way too much before

@jebbyk
Copy link
Owner

jebbyk commented Apr 13, 2021

technically only thing we need is to sample sun/moon texture only in center of a sun/moon plane and programmelly draw a hall around it

@jebbyk
Copy link
Owner

jebbyk commented Apr 13, 2021

I don't like big amount of empty space in sun/moon textures too

@OpenSauce04
Copy link
Contributor Author

I'm not really familiar enough with GLSL to do that, so you'll have to work that out
For now, I'm working on a solution to draw the halo using the old system.

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 13, 2021

How's this? (Still got to make some adjustments to the moon)
Screenshot_20210413-125615_Minecraft.jpg
Screenshot_20210413-125539_Minecraft.jpg

@jebbyk
Copy link
Owner

jebbyk commented Apr 13, 2021

I think something between current intencity and "before" intencity will be ideal

@OpenSauce04
Copy link
Contributor Author

Here's the new moon I just finished
Screenshot_20210413-133227_Minecraft.jpg

@OpenSauce04
Copy link
Contributor Author

I think something between current intencity and "before" intencity will be ideal

I think this is bright enough
Any brighter and the sky would just look white wherever the sun is with no detail whatsoever

@OpenSauce04
Copy link
Contributor Author

Do you want me to do another poll -_-

@jebbyk
Copy link
Owner

jebbyk commented Apr 13, 2021

I want vanilla sun and moon texture :-D and just a bit brighter halo (idk maybe 25 - 50% brighter)

@OpenSauce04 OpenSauce04 force-pushed the Better-Sun-Moon-Textures branch from 6d47468 to d996efc Compare April 20, 2021 12:34
@OpenSauce04 OpenSauce04 force-pushed the Better-Sun-Moon-Textures branch from bc23f89 to 7cf0157 Compare April 25, 2021 08:48
@jebbyk
Copy link
Owner

jebbyk commented Apr 27, 2021

ALGTM. Gonna check it on my phone and merge

@OpenSauce04
Copy link
Contributor Author

OpenSauce04 commented Apr 28, 2021

ALGTM. Gonna check it on my phone and merge

Is this still happening or?

@jebbyk
Copy link
Owner

jebbyk commented Apr 28, 2021

sorry im just trying to find a minute to do this. University and work takes a lot of time :-(

@jebbyk jebbyk merged commit f3b470a into jebbyk:develop Apr 28, 2021
@OpenSauce04 OpenSauce04 deleted the Better-Sun-Moon-Textures branch April 28, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants