Update rubocop and fix warnings

Gemfile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 ruby "~> #{`cat .ruby-version`.strip}"
@@ -30,8 +31,9 @@ group :development do
   gem 'guard-shell', require: false
   gem 'invoker', '1.5.1'
   gem 'rack-toolbar'
-  gem 'rubocop', '~> 0.47.1'
+  gem 'rubocop', '~> 0.49.1'
   gem 'spring'
+  gem 'spring-commands-rubocop', require: false
   gem 'terminal-notifier-guard'
   gem 'web-console', '~> 3.0'
 end

Gemfile.lock

@@ -130,6 +130,7 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
+    parallel (1.11.2)
     parser (2.4.0.0)
       ast (~> 2.2)
     pg (0.21.0)
@@ -177,7 +178,8 @@ GEM
     rb-fsevent (0.9.8)
     rb-inotify (0.9.9)
       ffi (~> 1.0)
-    rubocop (0.47.1)
+    rubocop (0.49.1)
+      parallel (~> 1.10)
       parser (>= 2.3.3.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
@@ -199,6 +201,8 @@ GEM
     slop (3.6.0)
     spring (2.0.2)
       activesupport (>= 4.2)
+    spring-commands-rubocop (0.2.0)
+      spring (>= 1.0, < 3.0)
     sprockets (3.7.1)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -250,9 +254,10 @@ DEPENDENCIES
   rack-toolbar
   rails (= 5.1.1)
   rails_12factor
-  rubocop (~> 0.47.1)
+  rubocop (~> 0.49.1)
   slim-rails
   spring
+  spring-commands-rubocop
   terminal-notifier-guard
   web-console (~> 3.0)
   webpacker

Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
@@ -12,5 +13,5 @@ if Rails.env.development? || Rails.env.test?
     t.options = RUBOCOP_OPTS
   end
 
-  task default: [:test, :rubocop]
+  task default: %i[test rubocop]
 end

app/channels/application_cable/channel.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file. Action Cable runs in an EventMachine loop that does not support auto reloading.
 module ApplicationCable
   class Channel < ActionCable::Channel::Base

app/channels/application_cable/connection.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file. Action Cable runs in an EventMachine loop that does not support auto reloading.
 module ApplicationCable
   class Connection < ActionCable::Connection::Base

app/controllers/application_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.

app/controllers/spots_controller.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
+
 class SpotsController < ApplicationController
-  before_action :set_spot, only: [:edit, :update, :destroy]
+  before_action :set_spot, only: %i[edit update destroy]
 
   # GET /spots
   # GET /spots.json

app/helpers/application_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ApplicationHelper
   def height_range(min, max)
     return unless min && max

app/helpers/spots_helper.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 module SpotsHelper
 end

app/jobs/application_job.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
 end

app/mailers/application_mailer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class ApplicationMailer < ActionMailer::Base
   default from: '[email protected]'
   layout 'mailer'

app/models/api_request.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 class ApiRequest < ApplicationRecord
 end

app/models/application_record.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end

app/models/forecast.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class Forecast < ApplicationRecord
   extend ApiMethods
   self.abstract_class = true
@@ -45,7 +46,7 @@ def forecasted_max(stamps)
   private
 
     def raise_not_implemented_error
-      raise NotImplementedError, "Subclass should override method '#{caller[0][/`.*'/][1..-2]}'"
+      raise NotImplementedError, "Subclass should override method '#{caller(0..0).first[/`.*'/][1..-2]}'"
     end
   end
 end

app/models/msw.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class Msw < Forecast
   def avg_height
     (min_height + max_height) / 2

app/models/spitcast.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class Spitcast < Forecast
   class << self
     def site_url

app/models/spot.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
+
 class Spot < ApplicationRecord
   extend FriendlyId
-  friendly_id :name, use: [:slugged, :finders]
+  friendly_id :name, use: %i[slugged finders]
 
   has_many :surfline_nearshores
   has_many :surfline_lolas

app/models/surfline.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class Surfline < Forecast
   self.abstract_class = true
 
@@ -78,7 +79,7 @@ def parse_response(_spot, request, responses)
         spot_data = forecasts[spot_id]
         # [1..-2] gets all elements except first & last
         spot_data.keys[1..-2].each_with_index do |tstamp, index|
-          next unless spot_data[:swell_rating].blank?
+          next if spot_data[:swell_rating].present?
           prev_tstamp = spot_data.keys[index] # index is already offset by 1
           next_tstamp = spot_data.keys[index + 2]
           prev_rating = spot_data[prev_tstamp][:swell_rating]

app/models/surfline_lola.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class SurflineLola < Surfline
   class << self
     def api_url(spot)

app/models/surfline_nearshore.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class SurflineNearshore < Surfline
   class << self
     def api_url(spot)

app/models/water_quality.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class WaterQuality < ApplicationRecord
   extend ApiMethods
 

app/models/water_quality_department.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class WaterQualityDepartment < ApplicationRecord
   has_many :water_qualities
 end

app/views/spots/index.json.jbuilder

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 json.array!(@spots) do |spot|
   json.extract! spot, :id, :name, :lat, :lon, :surfline_id, :msw_id, :spitcast_id, :wunder_id
   json.url spot_url(spot, format: :json)

app/views/spots/show.json.jbuilder

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
+
 json.extract! @spot, :id, :name, :lat, :lon, :surfline_id, :msw_id, :spitcast_id, :wunder_id, :created_at, :updated_at

bin/rubocop

@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby
+begin
+  load File.expand_path('../spring', __FILE__)
+rescue LoadError => e
+  raise unless e.message.include?('spring')
+end
+require 'bundler/setup'
+load Gem.bin_path('rubocop', 'rubocop')

config.ru

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

config/application.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require File.expand_path('../boot', __FILE__)
 
 require 'rails/all'
@@ -15,7 +16,7 @@ class Application < Rails::Application
 
     config.time_zone = 'Pacific Time (US & Canada)'
 
-    config.autoload_paths += %W(#{config.root}/lib)
+    config.autoload_paths += %W[#{config.root}/lib]
 
     config.force_ssl = true
   end

config/boot.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
 
 require 'bundler/setup' # Set up gems listed in the Gemfile.

config/environment.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Load the Rails application.
 require File.expand_path('../application', __FILE__)
 

config/environments/development.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

config/environments/production.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

config/environments/test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

config/initializers/active_record_belongs_to_required_by_default.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Require `belongs_to` associations by default. This is a new Rails 5.0 default,

config/initializers/assets.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

config/initializers/callback_terminator.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Do not halt callback chains when a callback returns false. This is a new Rails 5.0 default,

config/initializers/cookies_serializer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This is a new Rails 5.0 default, so introduced as a config to ensure apps made with earlier versions of Rails aren't affected when upgrading.

config/initializers/filter_parameter_logging.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

config/initializers/friendly_id.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # FriendlyId Global Configuration
 #
 # Use this to set up shared configuration options for your entire application.
@@ -17,8 +18,8 @@
   # undesirable to allow as slugs. Edit this list as needed for your app.
   config.use :reserved
 
-  config.reserved_words = %w(new edit index session login logout users admin
-                             stylesheets assets javascripts images)
+  config.reserved_words = %w[new edit index session login logout users admin
+                             stylesheets assets javascripts images]
 
   #  ## Friendly Finders
   #

config/initializers/request_forgery_protection.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Enable origin-checking CSRF mitigation.

config/initializers/rubocop.rb

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
+
 RUBOCOP_OPTS = ['--rails', '--display-cop-names', '--auto-correct'].freeze

config/initializers/session_store.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.session_store :cookie_store, key: '_meta-surf-forecast_session'

config/initializers/wrap_parameters.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

config/routes.rb

@@ -5,7 +5,7 @@
     get '/(*path)' => redirect { |_params, req| "https://#{ENV['DOMAIN']}#{req.fullpath}" } if ENV['HOST'].present?
   end
 
-  resources :spots, only: [:index, :show]
+  resources :spots, only: %i[index show]
 
   root to: 'spots#index'
 end

config/spring.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-%w(
+
+%w[
   .ruby-version
   .rbenv-vars
   tmp/restart.txt
   tmp/caching-dev.txt
-).each { |path| Spring.watch(path) }
+].each { |path| Spring.watch(path) }

db/seeds.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 WaterQualityDepartment.find_or_create_by(code: 'LAPH') do |dept|
   dept.name = 'Los Angeles County Department of Public Health'
   dept.url = 'http://www.publichealth.lacounty.gov/phcommon/public/eh/water_quality/beach_grades.cfm'

lib/api_methods.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'open-uri'
 
 module ApiMethods

lib/tasks/cleanup.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 namespace :cleanup do
   desc 'Remove forecasts that are in the past'
   task prune_past_forecasts: :environment do

lib/tasks/msw.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 namespace :msw do
   desc 'Update forecast from MagicSeaweed'
   task update: :environment do

lib/tasks/spitcast.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 namespace :spitcast do
   desc 'Update forecast from Spitcast'
   task update: :environment do

lib/tasks/surfline.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 namespace :surfline do
   desc 'Update forecast from Surfline'
   task update: :environment do