Skip to content
This repository was archived by the owner on Apr 16, 2023. It is now read-only.

[WIP] Proposal for property change listeners on client objects#96

Draft
MarkTwoFive wants to merge 1 commit into
bleeding-1.X.Xfrom
t/dh-property-listeners
Draft

[WIP] Proposal for property change listeners on client objects#96
MarkTwoFive wants to merge 1 commit into
bleeding-1.X.Xfrom
t/dh-property-listeners

Conversation

@MarkTwoFive
Copy link
Copy Markdown
Member

Introduces property change listeners on special IDataHolder instances.
Proposed implementation:

  • Synchronously run listeners directly after the property has been changed.
  • Defer running listeners during client cache update and run them after the update is completed
  • Document that changing properties in an update listener is considered an anti-pattern but do not enforce.
  • TODO: Document that listeners should not be invoking any sort of load bearing code due to their synchronous nature.
  • TODO: Write documentation about this feature on ReadMe.IO

Closes: #95

@MarkTwoFive MarkTwoFive added this to the Stable Release 1.1.0 milestone Sep 5, 2019
@MarkTwoFive
Copy link
Copy Markdown
Member Author

@Genius42 please review the proposed API addition.

@MarkTwoFive MarkTwoFive self-assigned this Sep 25, 2019
@MarkTwoFive MarkTwoFive added api Related to API changes / additions (internal API) performance Performance impacting stuff ts-workaround Work-arounds for inconsistencies or bugs in TeamSpeak's API. labels Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api Related to API changes / additions (internal API) performance Performance impacting stuff ts-workaround Work-arounds for inconsistencies or bugs in TeamSpeak's API.

Development

Successfully merging this pull request may close these issues.

[🚀] Custom event when significant client properties change

2 participants