Conversation
jdrouet
force-pushed
the
fix/pool-clone-bound
branch
from
393fe1e to
7270ecb
Compare
The derived Clone implementation adds an implicit DB: Clone bound, which breaks downstream code because sqlx database markers like Postgres and Sqlite don't implement Clone. sqlx::Pool<DB> itself is Clone regardless of DB, so a manual impl drops the spurious bound. Adds compile-time assertions for Pool<Postgres> and Pool<Sqlite>.
jdrouet
force-pushed
the
fix/pool-clone-bound
branch
from
7270ecb to
f743f35
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[derive(Clone)]onPool<DB>with a manual impl, dropping the spuriousDB: Clonebound (sqlx database markers likePostgres/Sqlitedon't implementClone, butsqlx::Pool<DB>itself does).assert_clonechecks forPool<Postgres>andPool<Sqlite>to lock in the contract.Alternative to #6, addressing review feedback: drops the unrelated
inner.into()change, keepsself.attributes.clone()for consistency with the rest of the file, and mirrors the test on the sqlite side. No version bump, leave that to the next release.