Speed up #11
Speed up #11
Conversation
jdleo
commented
Oct 19, 2025
jdleo
commented
- Introduced character set constants for improved readability and maintainability.
- Updated IDGen struct for backward compatibility while promoting the use of package constants.
- Enhanced Generate and GenerateUnsecure methods with better error handling and optimized random byte generation.
- Added support for power-of-2 length alphabets to improve performance in ID generation.
- Introduced character set constants for improved readability and maintainability. - Updated IDGen struct for backward compatibility while promoting the use of package constants. - Enhanced Generate and GenerateUnsecure methods with better error handling and optimized random byte generation. - Added support for power-of-2 length alphabets to improve performance in ID generation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import ( | ||
| "crypto/rand" | ||
| "errors" | ||
| rand2 "math/rand" | ||
| "time" | ||
| rand2 "math/rand/v2" |
There was a problem hiding this comment.
Switching the unsecure generator to math/rand/v2 implicitly raises the minimum supported Go version to 1.22+, but the module still advertises Go 1.16 and nothing else in the change communicates a version bump. Consumers compiling this library with Go 1.16–1.21 will now fail with cannot find package math/rand/v2. Either keep using the original math/rand API or update go.mod/documentation to reflect the newer requirement.
Useful? React with 👍 / 👎.
