#2420 の変更提案プルリクエスト #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Dec 20, 2024
Comment on lines
-4
to
+5
| class="mora-table" | ||
| :class="[isActive && 'mora-table-focus', uiLocked || 'mora-table-hover']" | ||
| class="accent-phrase" | ||
| :class="[ |
Author
There was a problem hiding this comment.
「コンポーネント名と同じクラス名はテストでも使って良い」というVOICEVOXの独自方針があるので、クラス名を変えちゃいました！
jdkfx
merged commit 83e9b11
into
jdkfx:tests/#1462_accent_yomi_input_change
6 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
の変更提案プルリクです！
mergeしていただければ自動的に元のプルリクに反映されるはずです。
もちろんmergeせず自由に変更いただいても問題ないです！